Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix watch descriptors not updating when moving nested subdirectories #574

Closed
wants to merge 1 commit into from
Closed

Fix watch descriptors not updating when moving nested subdirectories #574

wants to merge 1 commit into from

Conversation

BoboTiG
Copy link
Collaborator

@BoboTiG BoboTiG commented Jun 11, 2019

Original patch by Zack Morris (@zackmorris) on issue #325.

@BoboTiG BoboTiG mentioned this pull request Jun 11, 2019
Closed
@BoboTiG
Copy link
Collaborator Author

BoboTiG commented Jun 11, 2019

@rrzaripov do you mind reviewing this one too? It may help with #514 too.

@rrzaripov
Copy link
Contributor

@BoboTiG this patch very similar to #515, so I think this one we can to close.

@BoboTiG
Copy link
Collaborator Author

BoboTiG commented Jul 1, 2019

Yep, do you think you can copy the test case into your branch?

@BoboTiG BoboTiG closed this Jul 1, 2019
@rrzaripov
Copy link
Contributor

@BoboTiG yes, I think this is good idea, test appended to #515

rrzaripov added a commit to rrzaripov/watchdog that referenced this pull request Jul 2, 2019
@rrzaripov
Added tests from gorakhargosh#574
92f3e29
rrzaripov added a commit to rrzaripov/watchdog that referenced this pull request Jul 2, 2019
@rrzaripov
Added tests from gorakhargosh#574
5068e7d
rrzaripov added a commit to rrzaripov/watchdog that referenced this pull request Jul 2, 2019
@rrzaripov
Added tests from gorakhargosh#574
caa9875
rrzaripov added a commit to rrzaripov/watchdog that referenced this pull request Jul 2, 2019
@rrzaripov
Added tests from gorakhargosh#574
858e7b4
@BoboTiG BoboTiG deleted the fix-issue-325-bad-path-moved-evt-subfolders-inotify-c branch July 2, 2019 16:30
BoboTiG pushed a commit that referenced this pull request Jul 2, 2019
@rrzaripov @BoboTiG
Fix wrong source path after renaming a top level folder
18bb843 
* Fix issue #325 and #514.
* Test added
* Added test for Windows
* Added tests from #574
CCP-Aporia pushed a commit to CCP-Aporia/watchdog that referenced this pull request Aug 13, 2020
@rrzaripov @BoboTiG
Fix wrong source path after renaming a top level folder
2acd299 
* Fix issue gorakhargosh#325 and gorakhargosh#514.
* Test added
* Added test for Windows
* Added tests from gorakhargosh#574
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug inotify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BoboTiG @rrzaripov