Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BSD] Pass tests with KqueueEmitter #637

Closed
8 tasks done
evilham opened this issue Feb 6, 2020 · 2 comments · Fixed by #641
Closed
8 tasks done

[BSD] Pass tests with KqueueEmitter #637

evilham opened this issue Feb 6, 2020 · 2 comments · Fixed by #641

Comments

@evilham
Copy link
Contributor

evilham commented Feb 6, 2020

Discovered while working on #632 which made watchdog not work on BSD systems.

By separating in two issues we can fix things progressively.

8 tests fail currently:

  • tests/test_emitter.py::test_create FAILED
  • tests/test_emitter.py::test_move_to FAILED
  • tests/test_emitter.py::test_separate_consecutive_moves FAILED
  • tests/test_emitter.py::test_fast_subdirectory_creation_deletion FAILED
  • tests/test_emitter.py::test_recursive_on FAILED
  • tests/test_emitter.py::test_recursive_off FAILED
  • tests/test_emitter.py::test_renaming_top_level_directory FAILED
  • tests/test_emitter.py::test_move_nested_subdirectories FAILED
@BoboTiG
Copy link
Collaborator

BoboTiG commented Feb 6, 2020

Could you post full errors 🙏?

@evilham
Copy link
Contributor Author

evilham commented Feb 7, 2020

:-D I can do better!
https://cirrus-ci.com/task/6078433516060672

evilham added a commit to CamilionEU/watchdog that referenced this issue Feb 7, 2020
evilham added a commit to CamilionEU/watchdog that referenced this issue Feb 7, 2020
BoboTiG pushed a commit that referenced this issue Feb 7, 2020
* [BSD] Pass tests \o/

Changes in kqueue observer:
- Some refactoring to have the data flow be clearer
- Conform better to what the test suite expects
- Be a bit more correct

* [BSD] Restore support (changelog)

Fixes #637

* [BSD] Restore support (review)
CCP-Aporia pushed a commit to CCP-Aporia/watchdog that referenced this issue Aug 13, 2020
* [BSD] Pass tests \o/

Changes in kqueue observer:
- Some refactoring to have the data flow be clearer
- Conform better to what the test suite expects
- Be a bit more correct

* [BSD] Restore support (changelog)

Fixes gorakhargosh#637

* [BSD] Restore support (review)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants