[BSD] Restore support #641
Conversation
|
You need to rebase your branch on master before adding the new commit. |
Changes in kqueue observer: - Some refactoring to have the data flow be clearer - Conform better to what the test suite expects - Be a bit more correct
|
This is awesome, many thanks @evilham !! |
|
In the Cirrus-CI report, there are those lines at the end: Exception in thread Thread-8:
Traceback (most recent call last):
File "/usr/local/lib/python3.7/threading.py", line 926, in _bootstrap_inner
self.run()
File "/tmp/cirrus-ci-build/src/watchdog/observers/api.py", line 145, in run
self.queue_events(self.timeout)
File "/tmp/cirrus-ci-build/src/watchdog/observers/kqueue.py", line 668, in queue_events
self.watch.is_recursive)
File "/tmp/cirrus-ci-build/src/watchdog/utils/dirsnapshot.py", line 253, in __init__
st = self.stat(path)
FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tmp_tebxtss/dir1'Does that mean the test was retried and passes? |
|
Thanks for the comment, totally missed that :-). Re: message, yeah, I think that test is marked as flaky and it passes on a second go; didn't observe that locally. It'd look like the directory gets removed before a new dir snapshot was created (L668); unsure if this is an error in kqueue or in dirsnapshot o.ô. Waiting for https://cirrus-ci.com/task/5449374754930688 to finish and check if it's flaky as well. |
|
If this is a random error, let's do nothing :) |
|
Yup, cirrus-ci didn't replicate that either: |
|
Merged, thank you for your time 🍾 |
|
Party! thank you for your kind assistance :-). |
* [BSD] Pass tests \o/ Changes in kqueue observer: - Some refactoring to have the data flow be clearer - Conform better to what the test suite expects - Be a bit more correct * [BSD] Restore support (changelog) Fixes gorakhargosh#637 * [BSD] Restore support (review)
See: https://cirrus-ci.com/task/5908114574671872
Fixes #637
For some reason GH is not taking into account that some commits are merged already? Maybe some cache issue...