Implement inotify file close events #690
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @lukassup, Thanks a lot for the patch! Do you mind adding a line in https://github.com/gorakhargosh/watchdog/blob/master/changelog.rst and a test? It would be perfect :) |
|
Should we make a difference between "write" and "nowrite" events? The later should not trigger a |
BoboTiG
requested changes
Oct 8, 2020
This reverts commit 69d61d0.
|
Thanks! Will do more extensive testing a bit later. |
|
Thanks to you 👍 |
ysard
added a commit
to ysard/watchdog
that referenced
this pull request
Jan 13, 2021
ysard
added a commit
to ysard/watchdog
that referenced
this pull request
Jan 14, 2021
ysard
added a commit
to ysard/watchdog
that referenced
this pull request
Jan 15, 2021
BoboTiG
pushed a commit
that referenced
this pull request
Jan 15, 2021
* add: inotify file close events * fix: NOWRITE_CLOSE doesn't modify dir * update changelog & version * add: test events * Revert "update changelog & version" This reverts commit 69d61d0. * update changelog * [gnu/linux] Fix ability to catch IN_CLOSE_WRITE, IN_CLOSE_NOWRITE events #690 * [gnu/linux] Test IN_CLOSE_WRITE, IN_CLOSE_NOWRITE events * Fix typos * [gnu/linux] Fix test due to IN_CLOSE_NOWRITE event * [gnu/linux] Revert IN_CLOSE_NOWRITE support #747 * [gnu/linux] Extend test for IN_CLOSE_WRITE support #747 * fix typos * Update changelog #747, #690 Co-authored-by: Lukas Šupienis <l.supienis@ncs.lt> Co-authored-by: Lukas Šupienis <lukas.supienis@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INotify-specific events for IN_WRITE_CLOSE and IN_NOWRITE_CLOSE