-
-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[inotify] Add support for the IN_CLOSE_WRITE event #747
Conversation
This reverts commit 69d61d0.
0de211c
to
c2a9b07
Compare
Great! Could you rebase your branch to fix conflicts? I did not look, but is it necessary for IN_CLOSE_NOWRITE to generate an event? If the file was not modified, then the event should not be sent. WDYT? |
Conflicts: changelog.rst src/watchdog/observers/inotify.py
It's now synced with master. I also fixed a test that failed in Travis. About the other point, it's a good question...
In practice, the use of IN_CLOSE_NOWRITE is probably uncommon and "can" generate a higher processing cost because the slightest file traversal by a program emits You will always find someone who needs an unimplemented event for a project... The safest thing to do would be to let the user choose the mask he is interested in; however the Inotify class (and the keyword argument Proof of the overhead with
With only IN_CLOSE_WRITE:
Other note: As indicated in the doc, the observers are specific to each OS (https://pythonhosted.org/watchdog/api.html#watchdog.observers.Observer). However, to give access to the event we are interested in here, it was necessary to modify the class This class is meant to be universal and this modification is not portable. As the issue #217 reminds us, we must warn the user that this method is only available under GNU/Linux. => Should I add a note in the docstring? The current issue is a long-standing problem (#245, #184, #313, #280, even #119 for the IN_ACCESS event). |
IMO the Could you do that?
IN_CLOSE_NOWRITE .
|
Could you add a line in the changelog (+ your GitHub nickename and @lukassup to our beloved contributors): - [inotify] Add support for ``IN_CLOSE_WRITE`` events. A ``FileCloseEvent`` event will be fired. Note that ``IN_CLOSE_NOWRITE`` events are not handled to prevent much noise. (`#184 <https://github.com/gorakhargosh/watchdog/pull/184>`_, `#245 <https://github.com/gorakhargosh/watchdog/pull/245>`_, `#280 <https://github.com/gorakhargosh/watchdog/pull/280>`_, `#313 <https://github.com/gorakhargosh/watchdog/pull/313>`_, `#690 <https://github.com/gorakhargosh/watchdog/pull/690>`_) |
b282300
to
090ab06
Compare
It's done now ;) |
Thanks a lot @ysard 💪 |
* Fix installation of Python 3.7.9 on Windows (#705) * [windows] winapi.BUFFER_SIZE now defaults to 64000 (instead of 2048) To handle cases with lot of changes, this seems the highest safest value we can use. Note: it will fail with `ERROR_INVALID_PARAMETER` when it is greater than 64 KB and the application is monitoring a directory over the network. This is due to a packet size limitation with the underlying file sharing protocols. https://docs.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-readdirectorychangesw#remarks Also introduced `winapi.PATH_BUFFER_SIZE` (defaults to `2048`) to keep the old behavior with path-realted functions. * [mac] Regression fixes for native fsevents (#717) * [mac] Fix missing event_id attribute in fsevents (#722) * [mac] Return byte paths if a byte path was given in fsevents (#726) * Pin py.test to a version that supports 2.7 * Disable pypy2 tests on Windows They hang and timeout after 6 hours for some unknown reason * [mac] Add compatibility with old macOS versions (#733) * Ensure version macros are available * Uniformize event for deletion of watched dir (#727) * [inotify] Add support for the IN_CLOSE_WRITE event (#747) * [mac] Support coalesced fsevents (#734) * Add `is_coalesced` property to `NativeEvent` So that we can effectively decide if we need to perform additional system calls to figure out what really happened. * Replace `NativeEvent._event_type` with `repr()` support It's more pythonic, and the `_event_type` implementation wasn't quite usable anyway. NB: the representation is not truly copy/paste python code if there is a double quote inside event.path, but that should be a rare case so we don't add the expensive special case handling there. * Allow running tests with debugger attached Some Python debuggers create additional threads, so we shouldn't assume that there is only one. * Request notifications for watched root * Expect events on macOS instead of using `time.sleep()` It might be even better to check for the emitter class, as opposed to platform * Add exception handling to FSEventsEmitter Reduce the amount of 'silent breakage' * Use sentinel event when setting up tests on macOS So that we can avoid a race between test setup and fseventsd * Improve handling of coalesced events * Revert accidental platform check change * Fix renaming_top_level_directory test on macOS * Generate sub events for move operations * Remove `filesystem_view` again While the `filesystem_view` helps with filtering out additional `FileCreatedEvent`+`DirModifiedEvent` pairs then it also introduces a huge amount of edge cases for synthetic events caused by move and rename operations. On top of that, in order to properly resolve those edge cases we'd have to go back to a solution very similar to the old directory snapshots, with all the performance penalties they suffered from... As such I think it's better to acknowledge the behaviour for coalesced events instead, and thus remove the `filesystem_view` again. * [mac] Improve handling of rename events (#750) * drop support for macOS 10.12 and lower Co-authored-by: SamSchott <ss2151@cam.ac.uk> Co-authored-by: Boris Staletic <boris.staletic@gmail.com> Co-authored-by: Mickaël Schoentgen <contact@tiger-222.fr> Co-authored-by: Dustin Ingram <di@users.noreply.github.com> Co-authored-by: ysard <ysard@users.noreply.github.com> Co-authored-by: Lukas Šupienis <l.supienis@ncs.lt> Co-authored-by: Lukas Šupienis <lukas.supienis@gmail.com>
is this implemented only for unix? |
Yes, |
the answer is yes :) tried in windows - on_close not working |
You meant Linux image, didn't you? It will not work for other Unixes -- as the |
Why it was not added to LoggingEventHandler? ... 😿 |
I finally heard you: f3dfc4b :) You should have open an issue, I didn't catch that until now 😅 |
Hi, after testing #690 I found that the event was still not captured by the "inotify.InotifyObserver" observer. Here are my additions to this PR that got me on track. This should also close #93.
Please note that IN_CLOSE_NOWRITE is triggered very often with the IN_ISDIR mask; those events are filtered, see:
https://github.com/ysard/watchdog/blob/0de211c9864bce310a8fd9e5634e6a3e1ea3f9bc/src/watchdog/observers/inotify.py#L178-L182
Some additional events (IN_ACCESS, IN_OPEN) could easily be added in the future.
I don't know how far you want to go in the inotify support because it implies to make the lib less portable so I don't add anything more.
Waiting for your review :)