Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [#294] Validator cant check the param of url #29

Merged
merged 2 commits into from
Nov 3, 2023
Merged

fix: [#294] Validator cant check the param of url #29

merged 2 commits into from
Nov 3, 2023

Conversation

hwbrzzl
Copy link
Contributor

@hwbrzzl hwbrzzl commented Nov 3, 2023

Closes #

πŸ“‘ Description

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

@codecov-commenter
Copy link

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Files Coverage Ξ”
context_request.go 63.17% <50.00%> (+0.25%) ⬆️

πŸ“’ Thoughts on this report? Let us know!.

@hwbrzzl hwbrzzl marked this pull request as ready for review November 3, 2023 04:36
@hwbrzzl hwbrzzl requested a review from a team November 3, 2023 04:36
devhaozi
devhaozi approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@devhaozi devhaozi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hwbrzzl hwbrzzl merged commit 0ed0d37 into master Nov 3, 2023
7 checks passed
@hwbrzzl hwbrzzl deleted the bowen/#294 branch November 3, 2023 14:01
@hwbrzzl hwbrzzl linked an issue Nov 4, 2023 that may be closed by this pull request
πŸ› [Bug] validator 无法树ιͺŒθ―·ζ±‚ηš„θ·―由参数 goravel/goravel#294
Closed
3 tasks
hwbrzzl added a commit that referenced this pull request Nov 9, 2023
@hwbrzzl @dependabot @juantarrel
v1.1.6 (#31)
a4b560d 
* build(deps): bump the go-modules group with 1 update (#28)

Bumps the go-modules group with 1 update: [github.com/bytedance/sonic](https://github.com/bytedance/sonic).

- [Release notes](https://github.com/bytedance/sonic/releases)
- [Commits](bytedance/sonic@v1.10.1...v1.10.2)

---
updated-dependencies:
- dependency-name: github.com/bytedance/sonic
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: go-modules
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix: [#294] Validator cant check the param of url (#29)

* fix: [#294] Validator cant check the param of url

* Optimize codecov

* feat: add terminal link to url (#30)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Juan Luis Talamante Arreola <juantarrel@gmail.com>
hwbrzzl added a commit that referenced this pull request Nov 20, 2023
@hwbrzzl @dependabot @juantarrel
chroe: Merge v1.1.x (#32)
8cc8ecd 
* v1.1.6 (#31)

* build(deps): bump the go-modules group with 1 update (#28)

Bumps the go-modules group with 1 update: [github.com/bytedance/sonic](https://github.com/bytedance/sonic).

- [Release notes](https://github.com/bytedance/sonic/releases)
- [Commits](bytedance/sonic@v1.10.1...v1.10.2)

---
updated-dependencies:
- dependency-name: github.com/bytedance/sonic
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: go-modules
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix: [#294] Validator cant check the param of url (#29)

* fix: [#294] Validator cant check the param of url

* Optimize codecov

* feat: add terminal link to url (#30)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Juan Luis Talamante Arreola <juantarrel@gmail.com>

* Remove goreleaesr

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Juan Luis Talamante Arreola <juantarrel@gmail.com>
hwbrzzl added a commit that referenced this pull request Mar 27, 2024
@hwbrzzl @dependabot @juantarrel
merge v1.1.7 (#53)
f1f3bf9 
* v1.1.6 (#31)

* build(deps): bump the go-modules group with 1 update (#28)

Bumps the go-modules group with 1 update: [github.com/bytedance/sonic](https://github.com/bytedance/sonic).

- [Release notes](https://github.com/bytedance/sonic/releases)
- [Commits](bytedance/sonic@v1.10.1...v1.10.2)

---
updated-dependencies:
- dependency-name: github.com/bytedance/sonic
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: go-modules
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix: [#294] Validator cant check the param of url (#29)

* fix: [#294] Validator cant check the param of url

* Optimize codecov

* feat: add terminal link to url (#30)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Juan Luis Talamante Arreola <juantarrel@gmail.com>

* Remove goreleaesr

* fix #378 (#51)

* Remove unnecessary code

* Remove unnecessary code

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Juan Luis Talamante Arreola <juantarrel@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devhaozi devhaozi devhaozi approved these changes

Assignees
No one assigned
Labels
πŸš€ Review Ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

πŸ› [Bug] validator 无法树ιͺŒθ―·ζ±‚ηš„θ·―由参数
3 participants
@hwbrzzl @codecov-commenter @devhaozi