Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add terminal link to url #30

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Conversation

juantarrel
Copy link
Contributor

Closes #

πŸ“‘ Description

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

image

Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement, could you please add this feature for https://github.com/goravel/fiber as well?

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests βœ…

Files Coverage Ξ”
route.go 88.88% <100.00%> (ΓΈ)

πŸ“’ Thoughts on this report? Let us know!.

@juantarrel
Copy link
Contributor Author

@hwbrzzl Done

@hwbrzzl hwbrzzl merged commit ecffb44 into goravel:master Nov 6, 2023
7 checks passed
hwbrzzl added a commit that referenced this pull request Nov 9, 2023
* build(deps): bump the go-modules group with 1 update (#28)

Bumps the go-modules group with 1 update: [github.com/bytedance/sonic](https://github.com/bytedance/sonic).

- [Release notes](https://github.com/bytedance/sonic/releases)
- [Commits](bytedance/sonic@v1.10.1...v1.10.2)

---
updated-dependencies:
- dependency-name: github.com/bytedance/sonic
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: go-modules
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix: [#294] Validator cant check the param of url (#29)

* fix: [#294] Validator cant check the param of url

* Optimize codecov

* feat: add terminal link to url (#30)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Juan Luis Talamante Arreola <juantarrel@gmail.com>
hwbrzzl added a commit that referenced this pull request Nov 20, 2023
* v1.1.6 (#31)

* build(deps): bump the go-modules group with 1 update (#28)

Bumps the go-modules group with 1 update: [github.com/bytedance/sonic](https://github.com/bytedance/sonic).

- [Release notes](https://github.com/bytedance/sonic/releases)
- [Commits](bytedance/sonic@v1.10.1...v1.10.2)

---
updated-dependencies:
- dependency-name: github.com/bytedance/sonic
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: go-modules
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix: [#294] Validator cant check the param of url (#29)

* fix: [#294] Validator cant check the param of url

* Optimize codecov

* feat: add terminal link to url (#30)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Juan Luis Talamante Arreola <juantarrel@gmail.com>

* Remove goreleaesr

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Juan Luis Talamante Arreola <juantarrel@gmail.com>
hwbrzzl added a commit that referenced this pull request Mar 27, 2024
* v1.1.6 (#31)

* build(deps): bump the go-modules group with 1 update (#28)

Bumps the go-modules group with 1 update: [github.com/bytedance/sonic](https://github.com/bytedance/sonic).

- [Release notes](https://github.com/bytedance/sonic/releases)
- [Commits](bytedance/sonic@v1.10.1...v1.10.2)

---
updated-dependencies:
- dependency-name: github.com/bytedance/sonic
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: go-modules
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix: [#294] Validator cant check the param of url (#29)

* fix: [#294] Validator cant check the param of url

* Optimize codecov

* feat: add terminal link to url (#30)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Juan Luis Talamante Arreola <juantarrel@gmail.com>

* Remove goreleaesr

* fix #378 (#51)

* Remove unnecessary code

* Remove unnecessary code

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Juan Luis Talamante Arreola <juantarrel@gmail.com>
@hwbrzzl
Copy link
Contributor

hwbrzzl commented Dec 18, 2024

Hey @juantarrel We created a private channel in Discord for contributors. You can click the link and DM me (@bowen) to join it if you are interested.

Here you can:

  1. Send PR link or review others' PRs;
  2. Discuss new features before creating an issue;
  3. Vote for something;
  4. etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants