Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v4] | [v2] BottomSheetBackdrop with opacity=0 doesn't work #1332

Closed
jslok opened this issue Mar 29, 2023 · 4 comments
Closed

[v4] | [v2] BottomSheetBackdrop with opacity=0 doesn't work #1332

jslok opened this issue Mar 29, 2023 · 4 comments
Labels
bug Something isn't working no-issue-activity

Comments

@jslok
Copy link

jslok commented Mar 29, 2023

Bug

Environment info

Library Version
@gorhom/bottom-sheet 4.4.5
react-native 0.70.7
react-native-reanimated 2.14.4
react-native-gesture-handler 2.9.0

Steps To Reproduce

Using the provided BottomSheetBackdrop, setting opacity={0} prevents the pressbehavior from working. Opacity level >= .1 returns the functionality, but of course makes the backdrop not fully transparent.

Describe what you expected to happen:

With opacity={0}, the backdrop should be fully transparent but still provide the pressBehavior to close the bottomsheet.

Reproducible sample code

  <BottomSheetBackdrop
    {...props}
    disappearsOnIndex={0}
    appearsOnIndex={1}
    opacity={0}
    enableTouchThrough
    pressBehavior={0}
  />
@jslok jslok added the bug Something isn't working label Mar 29, 2023
@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@jslok
Copy link
Author

jslok commented Apr 29, 2023

Not stale

@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions
Copy link

github-actions bot commented Jun 5, 2023

This issue was closed because it has been stalled for 5 days with no activity.

@github-actions github-actions bot closed this as completed Jun 5, 2023
thienguen added a commit to UNLV-CS472-672/2024-S-GROUP3-Barbell that referenced this issue Apr 10, 2024
@thienguen
🐞bug: gorhom/react-native-bottom-sheet#1332
2e7fb5b 
another broken lib
thienguen added a commit to UNLV-CS472-672/2024-S-GROUP3-Barbell that referenced this issue Apr 12, 2024
@thienguen @mva919
165 frontend headers, layouts and bugs (#166)
dc665a0 
* 🚰ci: collect coverage from api, and rename testing command

* 🗑️chore: shadcn removal, reduce bundle size

* 🗑️chore: where else do we delete useless stuff

* 🗑️chore: nah, fk nextjs

* 🐛fix: resolve conflict of tsconfig

and added fonts, a shit tons of it

* ✨feat: default header with gap, ass

* 🐛fix: expo jest now instead of test

* 🐛fix: fk snapshot got hands

* 🐧chore: try to manage packages, but realized we are too late for that

* 🐧chore: wasting

* ♻️chore: versions control

* ♻️chore: versions control II

* ♻️ feat: TUI turbo ITS FK GREAT

* 🐞bugs: fixed tailwind works on sum,d oesn't on others

https://www.nativewind.dev/quick-starts/react-native-cli

setup tailwind section

* 🐞fixed: single quote fixed, no body against it

* 🐧bug: attempt to use marcos bottom sheet,agasin, FAILED

* ♻️code: trash

* Revert "♻️code: trash"

This reverts commit 80d1940.

* 🐧fk: imma need input

* 🐧 ui: lets help others

* 🗑️chore: fixed pnpm audit and versions control, prisma latest

* 📁chore: sleep first, code after,

* 🐞bugS: fixed all your silly mistakes

* 🐞fixed: ts

* 🐧ui: atta boi, google gap-2

* 🐞fixed: help stef before

* 🐧masdasmdlkasd

* 🐧chore: chore

* ♻️ bugs: deployment realted

* 📁bug: wher am i

* ♻️fixed: testin and trpc typed

* 🐧ui: default header

* 🐞bugs: version version of pnpm up caniuse-lite

* 🐧 fluc: better message

* 🐞fluc: aight, real works this time

* 🐧ui: default header, background new color

* 🐧fluc: why tf I keep doing sidequest

* 🐞fixing: sdk 50 maybe, nativewind is ASS

* 🐧fluc: BEEFIEST update sdk

jesus why you do this to me

* ♻️tldr: nativewind/nativewind#628

* Auto stash before merge of "165-frontend-move-header-to-the-correct-location" and "origin/165-frontend-move-header-to-the-correct-location"

* Auto stash before merge of "165-frontend-move-header-to-the-correct-location" and "origin/165-frontend-move-header-to-the-correct-location"

* ⚙️tldr: java 17 instead of 11 now, FK YOU EXPO

* ⚙️tldr: fixing

https://docs.swmansion.com/react-native-gesture-handler/docs/fundamentals/installation

* 🐞bug: gorhom/react-native-bottom-sheet#1332

another broken lib

* 🐞bug: can't fix the bottom sheet, is beyond us

* 🐧feat: layout, 1

* 🐧fluc: layout 1 done,2 more to go

and get rid of the unsued import

* 🐧ui: picker...watf

* 🐧ui: im so sorry guys, workout screen

* 🐧ui: inbox screen structure

* 🐧ui: inbox structure done, now to friends

* 🐧ui: friends done,ui ready

* 🐧ci/cd: tesgting added

* 🐞fix: will write test in the next issue

* 🐧good to go

* 📁fixed: the damn LOGIN of CLERTK

* ♻️build: prisma schema migration init

* ♻️build: standardize ti

* 🐧build: comment out the eas

* 📁chore: fixed

* 📁chore: fixed

seed prod

* Add warning console log for null user data along with todo comment

---------

Co-authored-by: mva919 <mva919@gmail.com>
mva919 pushed a commit to UNLV-CS472-672/2024-S-GROUP3-Barbell that referenced this issue Apr 15, 2024
@thienguen
198 chore files allocation across repo and assign writing tests tasks…
89adcb8 
… to team (#199)

* 🚰ci: collect coverage from api, and rename testing command

* 🗑️chore: shadcn removal, reduce bundle size

* 🗑️chore: where else do we delete useless stuff

* 🗑️chore: nah, fk nextjs

* 🐛fix: resolve conflict of tsconfig

and added fonts, a shit tons of it

* ✨feat: default header with gap, ass

* 🐛fix: expo jest now instead of test

* 🐛fix: fk snapshot got hands

* 🐧chore: try to manage packages, but realized we are too late for that

* 🐧chore: wasting

* ♻️chore: versions control

* ♻️chore: versions control II

* ♻️ feat: TUI turbo ITS FK GREAT

* 🐞bugs: fixed tailwind works on sum,d oesn't on others

https://www.nativewind.dev/quick-starts/react-native-cli

setup tailwind section

* 🐞fixed: single quote fixed, no body against it

* 🐧bug: attempt to use marcos bottom sheet,agasin, FAILED

* ♻️code: trash

* Revert "♻️code: trash"

This reverts commit 80d1940.

* 🐧fk: imma need input

* 🐧 ui: lets help others

* 🗑️chore: fixed pnpm audit and versions control, prisma latest

* 📁chore: sleep first, code after,

* 🐞bugS: fixed all your silly mistakes

* 🐞fixed: ts

* 🐧ui: atta boi, google gap-2

* 🐞fixed: help stef before

* 🐧masdasmdlkasd

* 🐧chore: chore

* ♻️ bugs: deployment realted

* 📁bug: wher am i

* ♻️fixed: testin and trpc typed

* 🐧ui: default header

* 🐞bugs: version version of pnpm up caniuse-lite

* 🐧 fluc: better message

* 🐞fluc: aight, real works this time

* 🐧ui: default header, background new color

* 🐧fluc: why tf I keep doing sidequest

* 🐞fixing: sdk 50 maybe, nativewind is ASS

* 🐧fluc: BEEFIEST update sdk

jesus why you do this to me

* ♻️tldr: nativewind/nativewind#628

* Auto stash before merge of "165-frontend-move-header-to-the-correct-location" and "origin/165-frontend-move-header-to-the-correct-location"

* Auto stash before merge of "165-frontend-move-header-to-the-correct-location" and "origin/165-frontend-move-header-to-the-correct-location"

* ⚙️tldr: java 17 instead of 11 now, FK YOU EXPO

* ⚙️tldr: fixing

https://docs.swmansion.com/react-native-gesture-handler/docs/fundamentals/installation

* 🐞bug: gorhom/react-native-bottom-sheet#1332

another broken lib

* 🐞bug: can't fix the bottom sheet, is beyond us

* 🐧feat: layout, 1

* 🐧fluc: layout 1 done,2 more to go

and get rid of the unsued import

* 🐧ui: picker...watf

* 🐧ui: im so sorry guys, workout screen

* 🐧ui: inbox screen structure

* 🐧ui: inbox structure done, now to friends

* 🐧ui: friends done,ui ready

* 🐧ci/cd: tesgting added

* 🐞fix: will write test in the next issue

* 🐧good to go

* 📁fixed: the damn LOGIN of CLERTK

* ♻️build: prisma schema migration init

* ♻️build: standardize ti

* 🐧build: comment out the eas

* 📁chore: fixed

* 📁chore: fixed

seed prod

* 🗑️chore: files name and relative path

1. change all routers to..duh routers
2. update all relative path, even if it is test files
3. move all test file to a dedicated folder, avoid clutter
4. about to write picker-modal test

* 🗑️chore: okay, got it, WHO TF WROTE TOGGLE

* 🗑️chore: files name, dadadada

* 🗑️chore:f iles name change again

* 🤦‍♂️ci/cd; divider test pass, failed action-button

rename tests in api to router, specifically

* 🐧ci/cd: passed action-button, now onto picker-modal

* 🐧fluc: testing passed, more snapshot, fk me

* 🤦‍♂️ fluc: revertable, af FK CLERK

* 🤦‍♂️attempt: to fixed the stupid warning

* Revert "🤦‍♂️attempt: to fixed the stupid warning"

This reverts commit 5a6ad2f.

* 🤦‍♂️fixed: signed out fixed, now doing sign in, Jesus

* 🤦‍♂️idk: fk it

* 🐧updateD: snapshot

* ♻️chore: snapshot II

* 🐧fixed: jesus, writeing unit test and fix aaron toggle

* 🐧fluc: extend timeout

* 🤦‍♂️fluc: extend timeout

* 👑fluic: fk

* 🤦‍♂️remove: un need file

* ♻️fixed: ts error from main

* ♻️coverage: brrrr brrrrr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working no-issue-activity
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jslok