fix: removed rounding up from useNormalizedSnapPoints hook. #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gorhom
changed the title
mr-moto
added a commit
to mr-moto/react-native-bottom-sheet
that referenced
this pull request
Jan 9, 2021
fix: removed rounding up from useNormalizedSnapPoints hook. (gorhom#169)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
went ahead and fixed the cause of the modal not showing after the first dismiss.
_animatedIndexwas resulting in a decimal number causing_animatedIndex % 1 === 0to be false and never triggeringrunOnJS(handleOnChange)This caused the index to be stuck at 1 and did not trigger the
doDismissfunction inBottomSheetModal