fix: removed rounding up from useNormalizedSnapPoints hook. (#169) #1
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fixes #168 * chore: revert previous changes * chore: remove rounding up from use normalized snap points hook Co-authored-by: Mo Gorhom <gorhom@me.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes v3.0.2-alpha.0 introduces a bug that causes the onDismiss() to not be called on modal dismiss gorhom/react-native-bottom-sheet#168
chore: revert previous changes
chore: remove rounding up from use normalized snap points hook
Co-authored-by: Mo Gorhom gorhom@me.com
Please provide enough information so that others can review your pull request:
Motivation
Explain the motivation for making this change. What existing problem does the pull request solve?