Make goss compile on windows and enable travis tests on windows. #448
Conversation
I've extracted the unix-only part to file_unix.go and windows part to file_windows.go. I haven't found an easy way to support owners/groups on windows, so I've left it empty. TODO: figure out how to write and run integration tests on windows, but probably not this pr.
| return "", err | ||
| } | ||
|
|
||
| mode := fmt.Sprintf("%04o", (fi.Mode() & 07777)) |
There was a problem hiding this comment.
Note that fi.Mode has a bit different format from sys.(*syscall.Stat_t).Mode.
|
@stefan-improbable I'm interested in getting goss windows supported. How can I help? Is merging this the next step? |
@mhedgpeth it depends on @aelsabbahy whether he wants to merge this. We are using our fork at https://github.com/improbable/goss in the meantime, but we are hoping that we can merge our changes upstream and kill that fork. |
|
@aelindeman how can I help get this merged? What are your potential concerns? |
|
@mhedgpeth I think you meant @aelsabbahy. |
|
We're now publishing Windows and Mac OS binaries at https://github.com/improbable-eng/goss/releases (but we have not ensured all features work on all platforms). We're gradually making changes to get to feature parity with Linux. You're welcome to use and give feedback. |
|
superseded by #585 |
This includes go modules changes from #437 . I can update this PR once go_modules are merged upstream.