Skip to content

Commit

Permalink
Merge pull request #49 from lokst/use_full_classname
Browse files Browse the repository at this point in the history 
Output full classname as testcase classname attribute value
  • Loading branch information
@dnephin
dnephin committed Mar 12, 2019
2 parents 308fb9a + eb29bee commit c800bc8
Show file tree
Hide file tree
Showing 2 changed files with 48 additions and 49 deletions.
3 changes: 1 addition & 2 deletions internal/junitxml/report.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import (
"io"
"os"
"os/exec"
"path/filepath"
"strings"
"time"

Expand Down Expand Up @@ -154,7 +153,7 @@ func packageTestCases(pkg *testjson.Package) []JUnitTestCase {

func newJUnitTestCase(tc testjson.TestCase) JUnitTestCase {
return JUnitTestCase{
Classname: filepath.Base(tc.Package),
Classname: tc.Package,
Name: tc.Test,
Time: formatDurationAsSeconds(tc.Elapsed),
}
Expand Down
94 changes: 47 additions & 47 deletions internal/junitxml/testdata/junitxml-report.golden
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,80 +4,80 @@
<properties>
<property name="go.version" value="go7.7.7"></property>
</properties>
<testcase classname="." name="TestMain" time="0.000000">
<testcase classname="" name="TestMain" time="0.000000">
<failure message="Failed" type="">sometimes main can exit 2&#xA;FAIL&#x9;github.com/gotestyourself/gotestyourself/testjson/internal/badmain&#x9;0.010s&#xA;</failure>
</testcase>
</testsuite>
<testsuite tests="18" failures="0" time="0.020000" name="github.com/gotestyourself/gotestyourself/testjson/internal/good">
<properties>
<property name="go.version" value="go7.7.7"></property>
</properties>
<testcase classname="good" name="TestSkipped" time="0.000000">
<testcase classname="github.com/gotestyourself/gotestyourself/testjson/internal/good" name="TestSkipped" time="0.000000">
<skipped message="=== RUN TestSkipped&#xA;--- SKIP: TestSkipped (0.00s)&#xA;&#x9;good_test.go:23: &#xA;"></skipped>
</testcase>
<testcase classname="good" name="TestSkippedWitLog" time="0.000000">
<testcase classname="github.com/gotestyourself/gotestyourself/testjson/internal/good" name="TestSkippedWitLog" time="0.000000">
<skipped message="=== RUN TestSkippedWitLog&#xA;--- SKIP: TestSkippedWitLog (0.00s)&#xA;&#x9;good_test.go:27: the skip message&#xA;"></skipped>
</testcase>
<testcase classname="good" name="TestPassed" time="0.000000"></testcase>
<testcase classname="good" name="TestPassedWithLog" time="0.000000"></testcase>
<testcase classname="good" name="TestPassedWithStdout" time="0.000000"></testcase>
<testcase classname="good" name="TestWithStderr" time="0.000000"></testcase>
<testcase classname="good" name="TestNestedSuccess/a/sub" time="0.000000"></testcase>
<testcase classname="good" name="TestNestedSuccess/a" time="0.000000"></testcase>
<testcase classname="good" name="TestNestedSuccess/b/sub" time="0.000000"></testcase>
<testcase classname="good" name="TestNestedSuccess/b" time="0.000000"></testcase>
<testcase classname="good" name="TestNestedSuccess/c/sub" time="0.000000"></testcase>
<testcase classname="good" name="TestNestedSuccess/c" time="0.000000"></testcase>
<testcase classname="good" name="TestNestedSuccess/d/sub" time="0.000000"></testcase>
<testcase classname="good" name="TestNestedSuccess/d" time="0.000000"></testcase>
<testcase classname="good" name="TestNestedSuccess" time="0.000000"></testcase>
<testcase classname="good" name="TestParallelTheThird" time="0.000000"></testcase>
<testcase classname="good" name="TestParallelTheSecond" time="0.010000"></testcase>
<testcase classname="good" name="TestParallelTheFirst" time="0.010000"></testcase>
<testcase classname="github.com/gotestyourself/gotestyourself/testjson/internal/good" name="TestPassed" time="0.000000"></testcase>
<testcase classname="github.com/gotestyourself/gotestyourself/testjson/internal/good" name="TestPassedWithLog" time="0.000000"></testcase>
<testcase classname="github.com/gotestyourself/gotestyourself/testjson/internal/good" name="TestPassedWithStdout" time="0.000000"></testcase>
<testcase classname="github.com/gotestyourself/gotestyourself/testjson/internal/good" name="TestWithStderr" time="0.000000"></testcase>
<testcase classname="github.com/gotestyourself/gotestyourself/testjson/internal/good" name="TestNestedSuccess/a/sub" time="0.000000"></testcase>
<testcase classname="github.com/gotestyourself/gotestyourself/testjson/internal/good" name="TestNestedSuccess/a" time="0.000000"></testcase>
<testcase classname="github.com/gotestyourself/gotestyourself/testjson/internal/good" name="TestNestedSuccess/b/sub" time="0.000000"></testcase>
<testcase classname="github.com/gotestyourself/gotestyourself/testjson/internal/good" name="TestNestedSuccess/b" time="0.000000"></testcase>
<testcase classname="github.com/gotestyourself/gotestyourself/testjson/internal/good" name="TestNestedSuccess/c/sub" time="0.000000"></testcase>
<testcase classname="github.com/gotestyourself/gotestyourself/testjson/internal/good" name="TestNestedSuccess/c" time="0.000000"></testcase>
<testcase classname="github.com/gotestyourself/gotestyourself/testjson/internal/good" name="TestNestedSuccess/d/sub" time="0.000000"></testcase>
<testcase classname="github.com/gotestyourself/gotestyourself/testjson/internal/good" name="TestNestedSuccess/d" time="0.000000"></testcase>
<testcase classname="github.com/gotestyourself/gotestyourself/testjson/internal/good" name="TestNestedSuccess" time="0.000000"></testcase>
<testcase classname="github.com/gotestyourself/gotestyourself/testjson/internal/good" name="TestParallelTheThird" time="0.000000"></testcase>
<testcase classname="github.com/gotestyourself/gotestyourself/testjson/internal/good" name="TestParallelTheSecond" time="0.010000"></testcase>
<testcase classname="github.com/gotestyourself/gotestyourself/testjson/internal/good" name="TestParallelTheFirst" time="0.010000"></testcase>
</testsuite>
<testsuite tests="28" failures="4" time="0.020000" name="github.com/gotestyourself/gotestyourself/testjson/internal/stub">
<properties>
<property name="go.version" value="go7.7.7"></property>
</properties>
<testcase classname="stub" name="TestFailed" time="0.000000">
<testcase classname="github.com/gotestyourself/gotestyourself/testjson/internal/stub" name="TestFailed" time="0.000000">
<failure message="Failed" type="">=== RUN TestFailed&#xA;--- FAIL: TestFailed (0.00s)&#xA;&#x9;stub_test.go:34: this failed&#xA;</failure>
</testcase>
<testcase classname="stub" name="TestFailedWithStderr" time="0.000000">
<testcase classname="github.com/gotestyourself/gotestyourself/testjson/internal/stub" name="TestFailedWithStderr" time="0.000000">
<failure message="Failed" type="">=== RUN TestFailedWithStderr&#xA;this is stderr&#xA;--- FAIL: TestFailedWithStderr (0.00s)&#xA;&#x9;stub_test.go:43: also failed&#xA;</failure>
</testcase>
<testcase classname="stub" name="TestNestedWithFailure/c" time="0.000000">
<testcase classname="github.com/gotestyourself/gotestyourself/testjson/internal/stub" name="TestNestedWithFailure/c" time="0.000000">
<failure message="Failed" type="">=== RUN TestNestedWithFailure/c&#xA; --- FAIL: TestNestedWithFailure/c (0.00s)&#xA; &#x9;stub_test.go:65: failed&#xA;</failure>
</testcase>
<testcase classname="stub" name="TestNestedWithFailure" time="0.000000">
<testcase classname="github.com/gotestyourself/gotestyourself/testjson/internal/stub" name="TestNestedWithFailure" time="0.000000">
<failure message="Failed" type="">=== RUN TestNestedWithFailure&#xA;--- FAIL: TestNestedWithFailure (0.00s)&#xA;</failure>
</testcase>
<testcase classname="stub" name="TestSkipped" time="0.000000">
<testcase classname="github.com/gotestyourself/gotestyourself/testjson/internal/stub" name="TestSkipped" time="0.000000">
<skipped message="=== RUN TestSkipped&#xA;--- SKIP: TestSkipped (0.00s)&#xA;&#x9;stub_test.go:26: &#xA;"></skipped>
</testcase>
<testcase classname="stub" name="TestSkippedWitLog" time="0.000000">
<testcase classname="github.com/gotestyourself/gotestyourself/testjson/internal/stub" name="TestSkippedWitLog" time="0.000000">
<skipped message="=== RUN TestSkippedWitLog&#xA;--- SKIP: TestSkippedWitLog (0.00s)&#xA;&#x9;stub_test.go:30: the skip message&#xA;"></skipped>
</testcase>
<testcase classname="stub" name="TestPassed" time="0.000000"></testcase>
<testcase classname="stub" name="TestPassedWithLog" time="0.000000"></testcase>
<testcase classname="stub" name="TestPassedWithStdout" time="0.000000"></testcase>
<testcase classname="stub" name="TestWithStderr" time="0.000000"></testcase>
<testcase classname="stub" name="TestNestedWithFailure/a/sub" time="0.000000"></testcase>
<testcase classname="stub" name="TestNestedWithFailure/a" time="0.000000"></testcase>
<testcase classname="stub" name="TestNestedWithFailure/b/sub" time="0.000000"></testcase>
<testcase classname="stub" name="TestNestedWithFailure/b" time="0.000000"></testcase>
<testcase classname="stub" name="TestNestedWithFailure/d/sub" time="0.000000"></testcase>
<testcase classname="stub" name="TestNestedWithFailure/d" time="0.000000"></testcase>
<testcase classname="stub" name="TestNestedSuccess/a/sub" time="0.000000"></testcase>
<testcase classname="stub" name="TestNestedSuccess/a" time="0.000000"></testcase>
<testcase classname="stub" name="TestNestedSuccess/b/sub" time="0.000000"></testcase>
<testcase classname="stub" name="TestNestedSuccess/b" time="0.000000"></testcase>
<testcase classname="stub" name="TestNestedSuccess/c/sub" time="0.000000"></testcase>
<testcase classname="stub" name="TestNestedSuccess/c" time="0.000000"></testcase>
<testcase classname="stub" name="TestNestedSuccess/d/sub" time="0.000000"></testcase>
<testcase classname="stub" name="TestNestedSuccess/d" time="0.000000"></testcase>
<testcase classname="stub" name="TestNestedSuccess" time="0.000000"></testcase>
<testcase classname="stub" name="TestParallelTheThird" time="0.000000"></testcase>
<testcase classname="stub" name="TestParallelTheSecond" time="0.010000"></testcase>
<testcase classname="stub" name="TestParallelTheFirst" time="0.010000"></testcase>
<testcase classname="github.com/gotestyourself/gotestyourself/testjson/internal/stub" name="TestPassed" time="0.000000"></testcase>
<testcase classname="github.com/gotestyourself/gotestyourself/testjson/internal/stub" name="TestPassedWithLog" time="0.000000"></testcase>
<testcase classname="github.com/gotestyourself/gotestyourself/testjson/internal/stub" name="TestPassedWithStdout" time="0.000000"></testcase>
<testcase classname="github.com/gotestyourself/gotestyourself/testjson/internal/stub" name="TestWithStderr" time="0.000000"></testcase>
<testcase classname="github.com/gotestyourself/gotestyourself/testjson/internal/stub" name="TestNestedWithFailure/a/sub" time="0.000000"></testcase>
<testcase classname="github.com/gotestyourself/gotestyourself/testjson/internal/stub" name="TestNestedWithFailure/a" time="0.000000"></testcase>
<testcase classname="github.com/gotestyourself/gotestyourself/testjson/internal/stub" name="TestNestedWithFailure/b/sub" time="0.000000"></testcase>
<testcase classname="github.com/gotestyourself/gotestyourself/testjson/internal/stub" name="TestNestedWithFailure/b" time="0.000000"></testcase>
<testcase classname="github.com/gotestyourself/gotestyourself/testjson/internal/stub" name="TestNestedWithFailure/d/sub" time="0.000000"></testcase>
<testcase classname="github.com/gotestyourself/gotestyourself/testjson/internal/stub" name="TestNestedWithFailure/d" time="0.000000"></testcase>
<testcase classname="github.com/gotestyourself/gotestyourself/testjson/internal/stub" name="TestNestedSuccess/a/sub" time="0.000000"></testcase>
<testcase classname="github.com/gotestyourself/gotestyourself/testjson/internal/stub" name="TestNestedSuccess/a" time="0.000000"></testcase>
<testcase classname="github.com/gotestyourself/gotestyourself/testjson/internal/stub" name="TestNestedSuccess/b/sub" time="0.000000"></testcase>
<testcase classname="github.com/gotestyourself/gotestyourself/testjson/internal/stub" name="TestNestedSuccess/b" time="0.000000"></testcase>
<testcase classname="github.com/gotestyourself/gotestyourself/testjson/internal/stub" name="TestNestedSuccess/c/sub" time="0.000000"></testcase>
<testcase classname="github.com/gotestyourself/gotestyourself/testjson/internal/stub" name="TestNestedSuccess/c" time="0.000000"></testcase>
<testcase classname="github.com/gotestyourself/gotestyourself/testjson/internal/stub" name="TestNestedSuccess/d/sub" time="0.000000"></testcase>
<testcase classname="github.com/gotestyourself/gotestyourself/testjson/internal/stub" name="TestNestedSuccess/d" time="0.000000"></testcase>
<testcase classname="github.com/gotestyourself/gotestyourself/testjson/internal/stub" name="TestNestedSuccess" time="0.000000"></testcase>
<testcase classname="github.com/gotestyourself/gotestyourself/testjson/internal/stub" name="TestParallelTheThird" time="0.000000"></testcase>
<testcase classname="github.com/gotestyourself/gotestyourself/testjson/internal/stub" name="TestParallelTheSecond" time="0.010000"></testcase>
<testcase classname="github.com/gotestyourself/gotestyourself/testjson/internal/stub" name="TestParallelTheFirst" time="0.010000"></testcase>
</testsuite>
</testsuites>

0 comments on commit c800bc8

Please sign in to comment.