Some changes to foreground notification (channel) #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmattheis
approved these changes
Dec 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As already pointed out in #30, it is not possible on Android 8+ to set a minor priority to the foreground notification. But then, you are at least able to change the priority by hand (or even turn the notification completely off). On devices using API versions below 26, this fine-grained settings are not available to the user. Fortunately, in this case the restrictions mentioned above do not apply so when setting the priority on the notification itself to minimal it does have the effect of neither showing the notification on lockscreen nor the icon in the status bar.
By setting
.setWhen(0), the notification gets ordered at the bottom (at least on all phones I have tested) andforeground.setShowBadge(false)simply omits the foreground notification on the homescreen.