Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to build and run the plugin on RabbitMQ 3.7, I encountered two issues:
make dist
failed with the error:erlang.mk:6513: recipe for target '/root/rabbitmq-auth-backend-ip-range/.erlang.mk/list-deps.log' failed
rabbitmq-plugins list
did not detect the plugin andrabbitmq-plugins enable rabbitmq_auth_backend_ip_range
failedReplacing erlang.mk with the version from https://github.com/rabbitmq/rabbitmq-metronome fixed the issue with
make dist
.Adding
rabbit_common,rabbit,amqp_client
into theapplications
section of rabbitmq_auth_backend_ip_range.app.src (to match rabbitmq-metronome) fixed the issue withrabbitmq-plugins
not detecting the plugin.According to http://erlang.org/doc/man/app.html, the
mod
section of the app file is not necessary ("mod
can be omitted for applications without processes, typically code libraries, for example, STDLIB."), so I removed themod
section and rabbit_auth_backend_ip_range_app.erlChanged the version number from 0.2.0 to 3.7.0 since it seems that other plugins use the version of RabbitMQ that they are built for as their own version number.
Built, installed and tested on Debian 9 with RabbitMQ 3.7.4.