Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for RabbitMQ 3.7 #7

Closed
wants to merge 2 commits into from
Closed

Update for RabbitMQ 3.7 #7

wants to merge 2 commits into from

Conversation

youngj
Copy link

@youngj youngj commented Jun 16, 2018

When trying to build and run the plugin on RabbitMQ 3.7, I encountered two issues:

  • make dist failed with the error: erlang.mk:6513: recipe for target '/root/rabbitmq-auth-backend-ip-range/.erlang.mk/list-deps.log' failed
  • After fixing the compilation issue (or after downloading the pre-compiled .ez file from https://dl.bintray.com/rabbitmq/community-plugins/3.7.x/rabbitmq_auth_backend_ip_range) and installing it in /usr/lib/rabbitmq/plugins, rabbitmq-plugins list did not detect the plugin and rabbitmq-plugins enable rabbitmq_auth_backend_ip_range failed

Replacing erlang.mk with the version from https://github.com/rabbitmq/rabbitmq-metronome fixed the issue with make dist.

Adding rabbit_common,rabbit,amqp_client into the applications section of rabbitmq_auth_backend_ip_range.app.src (to match rabbitmq-metronome) fixed the issue with rabbitmq-plugins not detecting the plugin.

According to http://erlang.org/doc/man/app.html, the mod section of the app file is not necessary ("mod can be omitted for applications without processes, typically code libraries, for example, STDLIB."), so I removed the mod section and rabbit_auth_backend_ip_range_app.erl

Changed the version number from 0.2.0 to 3.7.0 since it seems that other plugins use the version of RabbitMQ that they are built for as their own version number.

Built, installed and tested on Debian 9 with RabbitMQ 3.7.4.

@lukebakken lukebakken self-assigned this Jun 18, 2018
@lukebakken lukebakken mentioned this pull request Jul 9, 2018
@lukebakken
Copy link
Collaborator

Thanks! I have incorporated your changes into PR #8. When it's ready I will let you know and you can test.

@lukebakken lukebakken closed this Jul 9, 2018
lukebakken added a commit that referenced this pull request Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants