Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR #7 with updates #8

Merged
merged 15 commits into from
Aug 1, 2018
Merged

PR #7 with updates #8

merged 15 commits into from
Aug 1, 2018

Conversation

lukebakken
Copy link
Collaborator

See #7

@lukebakken lukebakken self-assigned this Jul 9, 2018
@lukebakken lukebakken mentioned this pull request Jul 9, 2018
Closed
@lukebakken
Copy link
Collaborator Author

lukebakken commented Jul 31, 2018 •
edited
Loading

@youngj @ByteFlinger - please give this PR a test if you have time.

@lukebakken lukebakken requested a review from dumbbell July 31, 2018 23:09
michaelklishin
michaelklishin reviewed Jul 31, 2018
View reviewed changes
src/rabbit_auth_backend_ip_range.erl
@@ -27,6 +28,9 @@ description() ->
user_login_authorization(_Username) ->
{ok, none}.

user_login_authorization(_Username, _AuthProps) ->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function only exists in master. We'll need to omit it when backport for v3.7.x.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having the function there won't matter since it'll be unused, correct? Also, should we create a 3.7.x branch in this repo? I figured that after I merge this that point would become 3.7.x

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given it's a tier-2 plugin (i.e. not distributed with the broker), it would be awesome if there was a single codebase for 3.7.x and 3.8.x/master if possible. And if there is something we can do in RabbitMQ to allow that, then we should try to do it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, sounds good. I will leave this repo as is since having an extra function exported won't (shouldn't) matter.

dumbbell
dumbbell reviewed Aug 1, 2018
View reviewed changes
Copy link
Collaborator

@dumbbell dumbbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rabbitmq-components.mk seems to come from rabbitmq-common's master branch. It should probably be the one from v3.7.x instead.

@lukebakken
Copy link
Collaborator Author

Thanks @dumbbell I'll update that

@lukebakken lukebakken merged commit 4406191 into master Aug 1, 2018
@lukebakken lukebakken deleted the lrb-gh-7 branch August 1, 2018 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dumbbell dumbbell dumbbell left review comments

@michaelklishin michaelklishin michaelklishin approved these changes

Assignees

@lukebakken lukebakken

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lukebakken @michaelklishin @dumbbell @dcorbacho