-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conflict with Track Map Panels #80
Comments
On the Leaflet issue tracker, I can find Leaflet/Leaflet#1210, Leaflet/Leaflet#2606 and Leaflet/Leaflet#2607 which might be related. However, all of these have occurred at ~2012-2014 and should well have been mitigated already. Maybe it's also related to Leaflet/Leaflet#5774 in any way? Similar errors not with the exact same error text can also be found at [3]. |
We should update to the most recent version of Leaflet (see #79) and check if that might resolve this issue. |
Dear @DmitrySidorow, with #81, we will be upgrading to vanilla Leaflet 1.7.1. @robouden has been able to confirm the corresponding pre-release package grafana-map-panel-0.14.0-pre1.zip works for him. So, I am now humbly asking if you could check this package in your specific environment together with Grafana Track Map [1] and/or Alexandra Track Map [2] to see whether this might resolve the conflict you have been observing? With kind regards, |
issue still exists :(
how can i help you to resolve that? |
maybe log from chrome console will help you |
Dear Dmitry, thanks for sharing your investigations. For whatever reasons, the error might be coming from the
So, either This method gets called from the
Without knowing more details yet, the code at one of both places probably should add more sanity checks before operating on the respective It looks like Leaflet/Leaflet#5401, Leaflet/Leaflet#6168 and Leaflet/Leaflet#6406 are roughly related to this. While unrelated to this specific condition, Leaflet/Leaflet#7075 adds more tests for methods of the With kind regards, [1] https://github.com/Leaflet/Leaflet/blob/v1.7.1/dist/leaflet-src.js#L1038-L1052 |
@anykeyanykey says at Leaflet/Leaflet#6406 (comment):
|
Dear Dmitry, I've just also shared your observations at Leaflet/Leaflet#7334. With kind regards, |
noticed:
|
Dear Dmitry, thanks for outlining this repro. So, it looks like it is some initialization issue when using Leaflet on different dashboards without clearing the slate by reloading the page. Can I humbly ask if it also happens the other way round, when going to alexandra track map panel first? Also, does it also happen when navigating to other dashboards without any kind of map and back? With kind regards, |
I tried to loading the alexandra track map panel first. But this time nothing broke. From this, we can conclude that the problem is in grafana-map-panel. |
Bummer! ;]. You did use grafana-map-panel-0.14.0-pre1.zip, right? |
yes, 0.14.0-pre1 |
All right. Currently, I am out of ideas here. When Leaflet/Leaflet#7334 does not make any progress, I might apply some workarounds to our instance by monkeypatching it. As I am currently short on time, I humbly ask you for some patience - please ping me again if you don't hear back from me. Thanks for your support! |
Hello, how's it going? The problem still exists :( |
Hi Dmitry, thanks for coming back to this. I am sorry to admit I haven't investigated further. Also, Leaflet seems to be low on developer resources as well. This panel is already using the most recent version Nevertheless, I might be able to look into the Monkeypatching when I am back at the code base. Sorry that this causes some pains on your end. Just to clarify:
When watching [1] again, it problem appears when displaying the Map panel on one dashboard, then navigating to another dashboard with Trackmap panel and when navigating back to the Map panel, the circles will not come back, right? Instead of logging out and logging in again, what would happen if you reload the page by hitting F5? With kind regards, P.S.: Are you still using [2] or did you move on to [3]? [1] https://www.youtube.com/watch?v=UIRVn7Jtzkc |
At #80 (comment), I said:
That might also well be an option to investigate further, as this issue with Leaflet is apparently still not completely solved. |
Dear @DmitrySidorow,
Knowing about this would be helpful if I can catch a slot to rig up a similar setup on my workstation. With kind regards, |
I use [3] |
Hi Dmitry, thanks for letting me know. Now, in order to assist my test rig setup, would you be able to share some parts of your setup by any means? For exporting a subset of the data, InfluxDB Fetcher [1] might come to the rescue (do you actually use InfluxDB?). For Grafana Dashboards, the JSON representation will also be helpful. @Hualin-AUG just recently shared some bits with me for investigating another issue, see #88. If your setup is more private, you might choose to use a private gist and send the URL through email. Please note that this is just a humble suggestion how we could work together. If that is not possible, I will completely understand it. With kind regards, |
hi! |
Hi Dmitry, apologies that we did not find enough spare time to get into the details of this issue. By chance, the error might have been mitigated on more recent versions of Grafana, Panodata Map Panel, or Trackmap Panel. Did you have any chance to validate it, or are you still facing this issue? With kind regards, |
Hi there,
@DmitrySidorow reported about conflicts with Track Map panels at #47 (comment), grafana#283 and pR0Ps/grafana-trackmap-panel#43.
I seems to happen with both [1] and [2] and says
TypeError: Cannot read property 'x' of undefined
.Can you a) confirm that and b) have a look into the developer tools to see if you are able to get more information about this issue, Dmitry?
With kind regards,
Andreas.
cc @pR0Ps, @j-or, @CodeFunta, @mourner, @IvanSanchez
[1] https://github.com/pR0Ps/grafana-trackmap-panel
[2] https://github.com/alexandrainst/alexandra-trackmap-panel
The text was updated successfully, but these errors were encountered: