Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use vanilla Leaflet 1.7.1 #81

Merged
merged 1 commit into from
Nov 21, 2020
Merged

Use vanilla Leaflet 1.7.1 #81

merged 1 commit into from
Nov 21, 2020

Conversation

amotl
Copy link

@amotl amotl commented Nov 9, 2020

Closes #79.

About

This attempts to remove the Leaflet 1.3.1 included within the repository and replace it by a vanilla Leaflet 1.7.1 pulled in through package.json.

@amotl
Copy link
Author

amotl commented Nov 9, 2020

Dear @robouden and @matschaffer,

I've compiled this as grafana-map-panel-0.14.0-pre1.zip. Will you be able to test whether this still works?

From quickly taking a look into the Zip archive, I am not sure if it will work as I can't find any appearance of leaflet/dist/leaflet.css anywhere. However, making the beast at least compile again without Typescript croaking was the best I have been able to achieve for now.

With kind regards,
Andreas.

@robouden
Copy link

robouden commented Nov 9, 2020

Andreas

I will give it a try.

Regards,
Rob

@robouden
Copy link

robouden commented Nov 9, 2020 via email

@amotl
Copy link
Author

amotl commented Nov 9, 2020

Hi Rob,

I installed to plugin and it seems to work fine.

Thanks!

What do you want me to test with it?

If the rendering is still working after swapping the Leaflet implementation, I believe it will all be fine then. Thanks for your quick test!

Cheers,
Andreas.

@robouden
Copy link

robouden commented Nov 9, 2020

Andreas,

Yes, works fine.

Regards,
rob

@amotl amotl merged commit 2a6d382 into develop Nov 21, 2020
@amotl amotl deleted the stock-leaflet branch November 21, 2020 15:51
@amotl amotl mentioned this pull request Nov 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to most recent version of Leaflet
2 participants