Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grafana 8: Don't croak when unable to load/access KeybindingSrv #104

Merged
merged 1 commit into from
Jun 15, 2021

Conversation

amotl
Copy link

@amotl amotl commented Jun 9, 2021

Hi there,

this addresses #103.

Apparently, the KeybindingSrv service component will have to be addressed differently on Grafana 8. By now, the first patch 86d5db3 will just ignore / skip anything related to that, so we only lack minor functionality about »disabling keyboard navigation completely«, aka. the ignoreEscapeKey feature.

While this is a start, there might be more issues we will be running into, so we will be happy to receive any further reports from the community. Would someone also be available to verify this by building that branch using npx yarn dev and linking the dist folder into the Grafana plugin folder in order to check if the plugin with those improvements will actually work on real data?

With kind regards,
Andreas.

/cc @jm66, @MarcoPignati

Apparently, this service component will have to be addressed differently
on Grafana 8. By now, this update will just ignore / skip anything
related to that, so we only lack a minor feature about disabling
any keyboard navigation.
@birdayz
Copy link

birdayz commented Jun 10, 2021

i'd be happy to test with real data - having it available as release 0.15.1 would help!

@jm66
Copy link

jm66 commented Jun 10, 2021

Hello @amotl,

Thank you. Just tested it and works great with Grafana v8.0.1 (8849243d27).

Thanks,
JM

@amotl amotl merged commit c74d0fc into develop Jun 15, 2021
@amotl amotl deleted the collab/grafana8 branch June 15, 2021 14:39
@francescobianca
Copy link

@jm66 Could you send me a compiled version compatible with Grafana 8?

@andsens
Copy link

andsens commented Jul 7, 2021

@francescobianca

Could you send me a compiled version compatible with Grafana 8?

Take a gander here #103 (comment)

@jm66
Copy link

jm66 commented Jul 7, 2021

@francescobianca my apologies. I was out of the office but @andsens saved the day - thank you!

@amotl
Copy link
Author

amotl commented Aug 6, 2021

Hi there,

finally, I have been able to find some time to issue the regular release (0.16.0), see https://github.com/panodata/panodata-map-panel/releases/tag/0.16.0. We will be happy to receive any feedback how this version works.

Please note that the plugin name changed to panodata-map-panel in order to support #112.

With kind regards,
Andreas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants