-
Notifications
You must be signed in to change notification settings - Fork 487
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
pkg/prom/instance: create a ModalManager for ApplyConfig (#427)
* pkg/prom/instance: create a ModalManager for ApplyConfig ApplyConfig for the pkg/prom will need to be able to mutate the instance grouping mode and other settings. This PR enables that by doing the following: 1. Create a ModalManager that wraps around a GroupManager or a (new) DistinctManager. The ModalManager can change modes at the cost of needing to re-apply all instances. 2. Remove CountingManager and migrate its logic to ModalManager 3. Separate out storage of the ModalManager and BasicManager to be able to control both independently * remove DistinctManager, use underlying manager directly * simplify GroupManager.Stop * removed unused logger from GroupManager * document active/wrapped managers a bit better in ModalManager
- Loading branch information
Showing
9 changed files
with
259 additions
and
209 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.