pkg/prom/instance: create a ModalManager for ApplyConfig #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ApplyConfig for the pkg/prom will need to be able to mutate the instance grouping mode and other settings. This PR enables that by doing the following: 1. Create a ModalManager that wraps around a GroupManager or a (new) DistinctManager. The ModalManager can change modes at the cost of needing to re-apply all instances. 2. Remove CountingManager and migrate its logic to ModalManager 3. Separate out storage of the ModalManager and BasicManager to be able to control both independently
56quarters
approved these changes
Feb 24, 2021
3 tasks
mattdurham
pushed a commit
that referenced
this pull request
Nov 11, 2021
* pkg/prom/instance: create a ModalManager for ApplyConfig ApplyConfig for the pkg/prom will need to be able to mutate the instance grouping mode and other settings. This PR enables that by doing the following: 1. Create a ModalManager that wraps around a GroupManager or a (new) DistinctManager. The ModalManager can change modes at the cost of needing to re-apply all instances. 2. Remove CountingManager and migrate its logic to ModalManager 3. Separate out storage of the ModalManager and BasicManager to be able to control both independently * remove DistinctManager, use underlying manager directly * simplify GroupManager.Stop * removed unused logger from GroupManager * document active/wrapped managers a bit better in ModalManager
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
ApplyConfig for the pkg/prom ApplyConfig logic will need to be able to mutate the instance grouping mode and other settings. This PR enables that by doing the following:
Create a ModalManager that abstracts away the shared/distinct grouping logic. The ModalManager can change modes at the cost of needing to re-apply all instances.
Remove CountingManager and migrate its logic to ModalManager
Separate out storage of the ModalManager and BasicManager to be able to control both independently
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist