pkg/prom: implement ApplyConfig #435
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfratto
commented
Feb 26, 2021
Allows for deferring and changing implementation of a Server
rfratto
commented
Feb 26, 2021
Comment on lines
+24
to
+30
| // API can wire HTTP and gRPC routes. | ||
| type API struct { | ||
| mut sync.Mutex | ||
| server *Server | ||
| logger log.Logger | ||
| scrapingApi *deferredScrapingServiceServer | ||
| } |
There was a problem hiding this comment.
I'm not really happy with the need to do this. I need to think about updating config within a Server instead.
|
Moving to draft until I'm happier with the state of this. |
|
I'm going to close this. This will be superseded by a new PR that accounts for all the other pkg/prom refactoring work that's been going on. |
3 tasks
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR implements ApplyConfig for the Prometheus instance manager.
Which issue(s) this PR fixes
Partial implementation of #147.
Similar PRs: #416, #424, #427.
Notes to the Reviewer
The behavior here is easily the most drastic: changing the scraping service config can only be handled by leaving the cluster, changing the config, and rejoining.
PR Checklist