implement ApplyConfig for pkg/prom #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattdurham
approved these changes
Mar 17, 2021
| // because creating both this function and newInstance grab the mutex. | ||
| oldConfig := a.cfg | ||
|
|
||
| a.actor <- func() { |
There was a problem hiding this comment.
As you mentioned this feels less than ideal. This is fine if this is the best way to go forward given the situation, but feels like something we may have to pay off later.
There was a problem hiding this comment.
I'm thinking about it some more and we'll eventually be able to get rid of it once we consolidate the operational modes here and make the Agent always act as if it was clustered. We'd have a configstore.Local implementation and the config watcher would continue to sync the state with the local store in the background. It's still not great that it'll always be asynchronous. Maybe once we make that change another opportunity to simplify will pop up 🤞
mattdurham
pushed a commit
that referenced
this pull request
Nov 11, 2021
* implement ApplyConfig for pkg/prom * clean up comments
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Implements ApplyConfig for
pkg/prom.Agent.Which issue(s) this PR fixes
Related to #147.
Notes to the Reviewer
Alternative implementation of #435.
I don't really like how this works, and needing to have a goroutine to apply changed configs in the background feels bad. I've given some thought on other ways to do this, but this seems like the less ridiculous so far.
PR Checklist