Implement ApplyConfig for Tempo #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfratto
commented
Feb 22, 2021
| i.logger.Info(fmt.Sprintf("shutting down %s", dep.name)) | ||
| if err := dep.shutdown(); err != nil { | ||
| i.logger.Error(fmt.Sprintf("failed to shutdown %s", dep.name), zap.Error(err)) | ||
| } | ||
| } |
There was a problem hiding this comment.
@joe-elliott heads up: you were shutting down receivers twice, but I think you meant to shutdown the exporter here instead.
mattdurham
approved these changes
Feb 22, 2021
3 tasks
mattdurham
pushed a commit
that referenced
this pull request
Nov 11, 2021
* implement ApplyConfig for tempo * add integration tests, fix bugs in ApplyConfig from testing * i before e except after c * fix test failure
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR adds an ApplyConfig field for applying a new config to the Tempo subsystem. This isn't hooked into anything for now, but will be used as part of #147.
It works by checking to see if a Tempo instance config has changed, and replacing the OpenTelemetry-collector instance if it has. Instances that have been removed from the updated config will be shut down.
Which issue(s) this PR fixes
Related to #147, but doesn't implement it fully.
Notes to the Reviewer
Related to #416 which did the same for Loki.
PR Checklist