Implement ApplyConfig for Loki #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfratto
force-pushed
the
loki-applyconfig
branch
from
a11edab
to
9a14a49
Compare
56quarters
reviewed
Feb 18, 2021
rfratto
commented
Feb 18, 2021
| @@ -0,0 +1,135 @@ | |||
| //+build !race | |||
There was a problem hiding this comment.
There's a race condition in promtail itself, so I'm just going to not use the race detector here for now
56quarters
reviewed
Feb 18, 2021
56quarters
approved these changes
Feb 18, 2021
This was referenced Feb 22, 2021
mattdurham
pushed a commit
that referenced
this pull request
Nov 11, 2021
* Implement ApplyConfig for Loki * add integration test for ApplyConfig * fix lint, race errors, map deletion * make windows test happy
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR adds an
ApplyConfigfield for applying a new config to the Loki subsystem. This isn't hooked into anything for now, but will be used as part of #147.It works by checking to see if a Loki instance config has changed, and replacing the Promtail instance if it has. Instances that have been removed from the updated config will be shut down.
Which issue(s) this PR fixes
Related to #147, but doesn't implement it fully.
Notes to the Reviewer
PR Checklist