Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WAL appender does not reject series with empty label set or duplicate labels #527

Closed
rfratto opened this issue Apr 9, 2021 · 0 comments · Fixed by #528
Closed

WAL appender does not reject series with empty label set or duplicate labels #527

rfratto opened this issue Apr 9, 2021 · 0 comments · Fixed by #528
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.

Comments

@rfratto
Copy link
Member

rfratto commented Apr 9, 2021

See equivalent code from the Prometheus TSDB: https://github.com/prometheus/prometheus/blob/f3505da306405536248cbde3f4a07b95ff018005/tsdb/head.go#L1271-L1279

We need the same logic in the WAL appender.
@rfratto rfratto added the size/s label Apr 9, 2021
rfratto added a commit to rfratto/agent that referenced this issue Apr 9, 2021
@rfratto
validate label set coming through WAL Appender
b3809cf 
Closes grafana#527
@rfratto rfratto mentioned this issue Apr 9, 2021
Merged
3 tasks
rfratto added a commit that referenced this issue Apr 9, 2021
@rfratto
Validate labels (#528)
9bd03d1 
* validate label set coming through WAL Appender

Closes #527

* changelog

* tests
rfratto added a commit to rfratto/agent that referenced this issue Apr 9, 2021
@rfratto
Validate labels (grafana#528)
9bac6b5 
* validate label set coming through WAL Appender

Closes grafana#527

* changelog

* tests
rfratto added a commit that referenced this issue Apr 9, 2021
@rfratto
Validate labels (#528)
1bdc571 
* validate label set coming through WAL Appender

Closes #527

* changelog

* tests
mattdurham pushed a commit that referenced this issue Nov 11, 2021
@rfratto
Validate labels (#528)
5dcf59e 
* validate label set coming through WAL Appender

Closes #527

* changelog

* tests
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 23, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Validate labels rfratto/agent
1 participant
@rfratto