Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate labels #528

Merged
merged 3 commits into from
Apr 9, 2021
Merged

Validate labels #528

merged 3 commits into from
Apr 9, 2021

Conversation

rfratto
Copy link
Member

@rfratto rfratto commented Apr 9, 2021

PR Description

Copies the Prometheus TSDB label validation code to the WAL appender.

Which issue(s) this PR fixes

Fixes #527

Notes to the Reviewer

PR Checklist

  • CHANGELOG updated
  • Documentation added
  • Tests updated

@rfratto rfratto requested a review from mattdurham April 9, 2021 12:59
Copy link
Collaborator

@mattdurham mattdurham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rfratto rfratto merged commit 9bd03d1 into grafana:main Apr 9, 2021
@rfratto rfratto deleted the validate-labels branch April 9, 2021 13:24
rfratto added a commit to rfratto/agent that referenced this pull request Apr 9, 2021
* validate label set coming through WAL Appender

Closes grafana#527

* changelog

* tests
rfratto added a commit that referenced this pull request Apr 9, 2021
* validate label set coming through WAL Appender

Closes #527

* changelog

* tests
@mattdurham mattdurham mentioned this pull request Sep 7, 2021
3 tasks
mattdurham pushed a commit that referenced this pull request Nov 11, 2021
* validate label set coming through WAL Appender

Closes #527

* changelog

* tests
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Apr 13, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WAL appender does not reject series with empty label set or duplicate labels
2 participants