-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add sigv4 install script, fix bug #334
Conversation
Also fixes bug where the deployment scrape config was included with host filtering enabled, where the inverse should've been true.
$._config.kubernetes_scrape_configs | ||
else | ||
$._config.kubernetes_scrape_configs, | ||
$._config.kubernetes_scrape_configs + $._config.deployment_scrape_configs, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was the bug. When host filtering is enabled, it shouldn't include the deployment scrape configs.
@@ -0,0 +1,357 @@ | |||
apiVersion: v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is generated, don't need to review it directly
@@ -176,29 +176,6 @@ data: | |||
tls_config: | |||
ca_file: /var/run/secrets/kubernetes.io/serviceaccount/ca.crt | |||
insecure_skip_verify: false | |||
- bearer_token_file: /var/run/secrets/kubernetes.io/serviceaccount/token |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is generated, don't need to review it directly
Also fixes bug where the deployment scrape config was included with host filtering enabled, where the inverse should've been true.
PR Description
Adds a sigv4-specific install script.
Also fixes bug where the deployment scrape config was included with host filtering enabled, where the inverse should've been true. (cc @hjet, this fixes the duplicate default/kubernetes job)
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist