allow specifying installation namespace in script #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56quarters
approved these changes
Jan 20, 2021
mattdurham
pushed a commit
that referenced
this pull request
Nov 11, 2021
* allow specifying installation namespace in script * specify ARN and add to ServiceAccount annotation * fix NAMESPACE typo * add namespace to serviceaccount * add region * update changelog, docs
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Allows a custom installation namespace in the Kubernetes install scripts through replacing an environment variable.
This also tweaks errors to the sigv4 script found when testing out #334.
Which issue(s) this PR fixes
Closes #319
Notes to the Reviewer
PR Checklist