Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tempo] Automatic Logging #551
[Tempo] Automatic Logging #551
Changes from 19 commits
9cfe6d9
aed6b14
09d2464
6ee0a46
d161788
71482e5
ebc8aa7
1c88fdc
4dc4805
0082076
3ad6059
bdda148
74b72a2
f6463d9
7d3dc64
c974804
e0238ea
7e018c3
e967715
df7002e
2395de8
55d8f4e
c210739
7b6761c
a8338d5
0370820
71c8fd5
a0d6503
f345a73
dbcefc8
93c3033
c70d070
8633639
a05e17c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious: what enables this? Is it defining
automatic_logging
in the config or is it providing a value forloki_name
? Can we document which?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding
automatic_logging
will instantiate the processor, but it will fail with an error message if it can't find the providedloki_name
.