-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrations always running regardless of enabled flag #689
Merged
Merged
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
c9e476b
Enabled flag should drive collection
mattdurham afa2eee
Satisfy linter
mattdurham cce8999
Fix mock integration so it sets enabled = true by default
mattdurham 6808da7
Make enabled the equivalent of not being in the config, removing it a…
mattdurham 22f1d16
Fix issue where removing the config/disabling did NOT stop the scraper
mattdurham cd058b4
Remove whitespace
mattdurham e7b90a7
remove unneeded comment
mattdurham 0f9ca9c
Remove duplicated delete config
mattdurham bb362da
Update comments and add unit tests. Also had to fix mock integration …
mattdurham d752a4f
Simplify unit test
mattdurham b7f0e68
change case because of refactor
mattdurham a60942a
Merge remote-tracking branch 'origin/main' into enabled_issue
mattdurham 98895c0
filter integrations to enabled set
rfratto 8c4c896
Move check up to the first statement
mattdurham f90f44a
merge
mattdurham 7b1987f
fix merge
mattdurham 411ccde
Fix for double loop
mattdurham File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you create a new function and call it from integrations.Manager.ApplyConfig instead? Filtering the actual slice here will omit the config from the results of
/-/config
which might be a little confusing to users.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This got more complicated. When you remove a configuration it did not stop the scraper, so when a configuration is disabled/removed and reload called Agent would list scrape_error = 404. Since the integration had stopped but the scraper was still running.