fix: improve nested folder handling #1600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theSuess
requested review from
NissesSenap,
weisdd,
ishanjainn,
HVBE and
pb82
as code owners
theSuess
force-pushed
the
feat/folder-conditions
branch
from
1364555
to
385f05d
Compare
theSuess
force-pushed
the
feat/folder-conditions
branch
2 times, most recently
from
b5c9dd5
to
f5098e7
Compare
This fixes some issues around the move logic. The underlying issue was the way in which folder existence was checked. As the search folder endpoint does _not_ return nested folders, moving between folders was not possible. This fix prefers matching by UIDs first. Note that the introduction of nested folders implies that they will only work with folders created by the operator as names no longer need to be unique and the only way to keep track is to use the UID.
theSuess
force-pushed
the
feat/folder-conditions
branch
from
f5098e7
to
4e1214c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some issues around the move logic. The underlying issue was the way in which folder existence was checked. As the search folder endpoint does not return nested folders, moving between folders was not possible. This fix prefers matching by UIDs first.
Note that the introduction of nested folders implies that they will only work with folders created by the operator as names no longer need to be unique and the only way to keep track is to use the UID.
Also introduces status conditions for the folder resource to better debug issues.