fix: use correct folder uid to update permissions #1602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timp87
requested review from
NissesSenap,
weisdd,
ishanjainn,
theSuess,
HVBE and
pb82
as code owners
|
|
|
Good catch! I'll merge this in after #1600 with some minor adjustments |
theSuess
force-pushed
the
fix-grafanafolder-permission-reconciliation
branch
from
541d03f
to
9855012
Compare
theSuess
approved these changes
Jul 4, 2024
|
Moved the reassignment of the uid in the existing conditional to prevent adding another conditional & to use the correct uid in case we are using a preexisting folder |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently grafanafolder controller tries to update folder permission using CR UID no matter if the folder was created by dashboard controller earlier.