-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gRPC protocol updates #1480
gRPC protocol updates #1480
Conversation
902f9f4
to
301427e
Compare
|
||
{{< /code >}} | ||
|
||
### Handling special cases in message Marshaling/Unmarshaling |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if that section deserves a dedicated page in k6/net/grpc
JavaScript's API 🤔
The main reason why I haven't put it there is that Marshaling/Unmarshaling is not an API. But probably, it is worth cross-linking from the Invoke/Stream.on pages to this section once it is merged (don't want to do this in a single PR since there is a #1472 PR which could cause a lot of conflicts)
WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But probably, it is worth cross-linking from the Invoke/Stream.on pages to this section once it is merged (don't want to do this in a single PR since there is a #1472 PR which could cause a lot of conflicts)
Yeah, let's do this 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@olegbespalov Congrats and thanks for this. 🎉
It sounds like a very good starting point. @dgzlopes it would be good to know your feeling about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great @olegbespalov! A much-needed improvement for this page. Thanks for working on it ❤️
LGTM
|
||
{{< /code >}} | ||
|
||
### Handling special cases in message Marshaling/Unmarshaling |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But probably, it is worth cross-linking from the Invoke/Stream.on pages to this section once it is merged (don't want to do this in a single PR since there is a #1472 PR which could cause a lot of conflicts)
Yeah, let's do this 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few small comments, overall it looks great! 🚀 Glad we have more content and examples on this page. 🙇
Co-authored-by: Heitor Tashiro Sergent <heitortsergent@gmail.com>
What?
This PR aims to fill the gaps mentioned by @dgzlopes and provide a complete overview of the gRPC support in k6.
Checklist
Please fill in this template:
make docs
command locally and verified that the changes look good.Select one of these and delete the others:
If updating the documentation for the most recent release of k6:
docs/sources/next
folder of the documentation.docs/sources/v{most_recent_release}
folder of the documentation.If updating the documentation for the next release of k6:
docs/sources/next
folder of the documentation.Related PR(s)/Issue(s)
Closes #1378
Closes #1038