Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minIterationDuration must not apply in setup() and teardown() #1003

Closed
na-- opened this issue Apr 19, 2019 · 0 comments · Fixed by #1175
Closed

minIterationDuration must not apply in setup() and teardown() #1003

na-- opened this issue Apr 19, 2019 · 0 comments · Fixed by #1175
Assignees
@cuonglm
Labels
bug
Milestone
v0.26.0

Comments

@na--
Copy link
Member

na-- commented Apr 19, 2019

As this user reported in the community forum, minIterationDuration affects setup() and teardown(). That shouldn't be the case, it should only affect normal iterations.
@na-- na-- added the bug label Apr 19, 2019
@na-- na-- added this to the v0.26.0 milestone Aug 27, 2019
@cuonglm cuonglm self-assigned this Sep 25, 2019
cuonglm added a commit that referenced this issue Sep 25, 2019
@cuonglm
js: skip minIterationDuration in setup/teardown
cb7d20d 
Close #1003
@cuonglm cuonglm mentioned this issue Sep 25, 2019
Merged
cuonglm added a commit that referenced this issue Sep 25, 2019
@cuonglm
js: skip minIterationDuration in setup/teardown
504e1c6 
Close #1003
@cuonglm cuonglm changed the title minIterationDuration shouldn't apply in setup() and teardown() minIterationDuration must not apply in setup() and teardown() Sep 25, 2019
cuonglm added a commit that referenced this issue Sep 25, 2019
@cuonglm
js: skip minIterationDuration in setup/teardown
33c02de 
Close #1003
cuonglm added a commit that referenced this issue Sep 25, 2019
@cuonglm
js: skip minIterationDuration in setup/teardown
bed4bfe 
Close #1003
cuonglm added a commit that referenced this issue Sep 25, 2019
@cuonglm
js: skip minIterationDuration in setup/teardown
19b4180 
Close #1003
cuonglm added a commit that referenced this issue Sep 26, 2019
@cuonglm
js: skip minIterationDuration in setup/teardown
9197621 
Close #1003
cuonglm added a commit that referenced this issue Sep 26, 2019
@cuonglm
js: skip minIterationDuration in setup/teardown
6a431fb 
Close #1003
cuonglm added a commit that referenced this issue Sep 27, 2019
@cuonglm
js: skip minIterationDuration in setup/teardown
94b3daa 
Close #1003

js: drop *lib.State return from runFn

The state returned by runFn is never used anywhere, so drop it.
cuonglm added a commit that referenced this issue Sep 27, 2019
@cuonglm
js: skip minIterationDuration in setup/teardown
01e43a8 
Close #1003

js: drop *lib.State return from runFn

The state returned by runFn is never used anywhere, so drop it.
cuonglm added a commit that referenced this issue Oct 18, 2019
@cuonglm
Ignore minIterationDuration in setup/teardown stage (#1175)
56cf629 
js: skip minIterationDuration in setup/teardown

Close #1003
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cuonglm cuonglm

Labels
bug
Projects
None yet
Milestone
v0.26.0
Development

Successfully merging a pull request may close this issue.

Ignore minIterationDuration in setup/teardown stage grafana/k6
2 participants
@na-- @cuonglm