Ignore minIterationDuration in setup/teardown stage #1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuonglm
changed the title
cuonglm
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1175 +/- ##
==========================================
- Coverage 73.65% 73.63% -0.03%
==========================================
Files 145 145
Lines 10603 10593 -10
==========================================
- Hits 7810 7800 -10
Misses 2334 2334
Partials 459 459
Continue to review full report at Codecov.
|
mstoykov
reviewed
Sep 25, 2019
mstoykov
reviewed
Sep 25, 2019
cuonglm
force-pushed
the
fix/1003
branch
2 times, most recently
from
bed4bfe
to
19b4180
Compare
imiric
reviewed
Sep 26, 2019
golangcibot
reviewed
Sep 26, 2019
mstoykov
reviewed
Sep 27, 2019
mstoykov
reviewed
Sep 27, 2019
mstoykov
reviewed
Sep 27, 2019
Close #1003 js: drop *lib.State return from runFn The state returned by runFn is never used anywhere, so drop it.
imiric
previously approved these changes
Oct 1, 2019
na--
reviewed
Oct 17, 2019
There was a problem hiding this comment.
Beside the minor nit I commented on inline, this change LGTM. Looking at the current overall architecture in runner.go, it definitely could be improved and probably needs to be refactored... But we can leave that task for the future, maybe when we work on #785...
na--
approved these changes
Oct 17, 2019
mstoykov
approved these changes
Oct 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minIterrationDurationis affecting setup/teardown stages. That should not be the case, and must only affect normal iteration only.So ignore
minterationDurationwhen in setup/teardown stage.Close #1003