Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of badssl.com in k6 tests #2302

Closed
mstoykov opened this issue Dec 17, 2021 · 0 comments · Fixed by #2543
Closed

Remove usage of badssl.com in k6 tests #2302

mstoykov opened this issue Dec 17, 2021 · 0 comments · Fixed by #2543

Comments

@mstoykov
Copy link
Collaborator

Currently, we are making external requests to badssl.com to test some specific SSL errors and compatibility with old versions 1 2 3.

This probably need to be looked over and seen if they are still all needed, there seems to be some repetition at first glance, and tried to use a local HTTPS server, which should be possible for all of them.

There is also a sample test which probably can stay as it is, I am just mentioning it for completeness.

The idea with not using an external site is both to make the tests more resilient to outside change, but also to make them faster, as making network requests outside of localhost is definitely slower. I would also recommend on not just adding all of this functionality to the httpmultibin but instead just specific server or even endpoints (not certain if possible) for the cases we care about.

This was extracted as the last part of #537, before closing it.

@mstoykov mstoykov mentioned this issue Dec 17, 2021
4 tasks
mstoykov added a commit that referenced this issue May 17, 2022
fixes #2302
@na-- na-- added this to the v0.40.0 milestone Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants