Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize test suite #537

Closed
2 of 4 tasks
na-- opened this issue Mar 16, 2018 · 3 comments
Closed
2 of 4 tasks

Optimize test suite #537

na-- opened this issue Mar 16, 2018 · 3 comments
Labels

Comments

@na--
Copy link
Member

na-- commented Mar 16, 2018

Currently the test suite is somewhat slow, and would probably become even slower after we start using the -race flag and add more tests. Steps:

  • Stop relying on httpbin.org for a lot of our tests.
  • Investigate if there are other external services that could be easily replaced as well. Remove them if there are, create issues for future releases if not.
  • Enable parallel execution of tests wherever possible with t.Parallel(). This should happen after the race conditions are fixed if we want to avoid headaches.
  • Investigate the test suite for any outliers with slow test execution. If there are any quick wins we could get by optimizing specific tests with minimal effort, fix them directly. Otherwise - document in separate issues.
@na-- na-- added this to the v0.21.0 milestone Mar 16, 2018
@na-- na-- added the tests label Mar 16, 2018
@na--
Copy link
Member Author

na-- commented Mar 21, 2018

Here are some of the external URLs I've noticed that we depend on in the unit tests while replacing httpbin:

  • demos.kaazing.com (for websockets, should be easy to replace) Done in c1de4e8
  • http2.akamai.com (should be easy to replace)
  • badssl.com (probably requires some time investment if there's no suitable Go library that mimics it)
  • microsoft.com (for checking for good OCSP status, we probably can't avoid an external call here...) (changed from stackoverflow.com in 9308833)

Others, if there are any, should pop up when the above are fixed and we run the tests locally without an internet connection.

@robingustafsson robingustafsson modified the milestones: v0.21.0, v1.0.0 May 23, 2018
@na-- na-- self-assigned this Jun 26, 2018
@na-- na-- removed this from the v1.0.0 milestone Oct 4, 2018
@na-- na-- removed their assignment Oct 4, 2018
@na--
Copy link
Member Author

na-- commented Oct 16, 2018

Something else that popped up, it seems like some of the tests can have huge memory leaks: #814
Further investigation definitely needed...

@mstoykov
Copy link
Collaborator

I am closing this as all but 1 change was made, and I have moved it to a specific issue #2302, please if any specific problems are noticed – open a specific issue for them instead of an “epic”.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants