-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ws): wrongly sending nil as error when write on close fails #1118
Conversation
I am expecting that this is the root cause of an issue reported in the community forum, as this is the only place where a nil error can be send :) I would've added tests but we are using some service to test websockets and I didn't find a way to have a write error with it in the 5 minutes I looked into it ... so maybe adding some priority to #537 and specifically the part with websockets ... it truly shouldn't be that hard to have something like httpbin for it |
Codecov Report
@@ Coverage Diff @@
## master #1118 +/- ##
==========================================
+ Coverage 73.54% 73.59% +0.05%
==========================================
Files 144 144
Lines 10531 10530 -1
==========================================
+ Hits 7745 7750 +5
+ Misses 2327 2322 -5
+ Partials 459 458 -1
Continue to review full report at Codecov.
|
98afb5b
to
8691681
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have websocket tests in the httpmultibin, so it shouldn't be too difficult to add a test for this? https://github.com/loadimpact/k6/blob/f2dff90edc83925399e738195e5617eaf7145398/lib/testutils/httpmultibin.go#L172-L173
Also, please write a PR description suitable for the release notes
8691681
to
3bee897
Compare
3bee897
to
149020c
Compare
No description provided.