Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the memory usage of a test #814

Merged
merged 1 commit into from
Oct 16, 2018
Merged

Reduce the memory usage of a test #814

merged 1 commit into from
Oct 16, 2018

Conversation

na--
Copy link
Member

@na-- na-- commented Oct 16, 2018

No description provided.

@na--
Copy link
Member Author

na-- commented Oct 16, 2018

@mstoykov, @robingustafsson - I'm directly merging this in master, to fix the build, but I intentionally doing it through a PR, so it'd be easier to reference in the future.
I'll create a new issue tomorrow that describes the things I've found out, but in short, the TestConsole test was taking over 1.2GB of RAM, and this fix dropped it back to 250-300 MB. We have some sort of memory sticking around when it should be garbage collected, and we probably have the same situation in other tests as well. Even worse, we might have something like this outside of the tests, in the actual k6 script execution... Hopefully not, but we should definitely investigate the root cause just in case.

@na-- na-- merged commit 427f1d6 into master Oct 16, 2018
@na-- na-- deleted the master-fix-2 branch October 16, 2018 21:55
@na-- na-- mentioned this pull request Oct 16, 2018
4 tasks
mstoykov added a commit that referenced this pull request Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant