fix: Always initialize filesystems for all schemes always #1097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was always done when running a script, but for archives it was deemed not needed as if it wasn't needed during the making of the archive it shouldn't be needed during it's running. The problem arises when a `require` is in a try block in order (to check if something is support for example). In that case if it isn't loaded (for example a nodejs module will not be loaded but will be resolved to an `https` url) it will not be cached. So if someone tries to run an archive from such a script and there were no https imports k6 will panic at runtime.
Codecov Report
@@ Coverage Diff @@
## master #1097 +/- ##
==========================================
+ Coverage 73.1% 73.11% +<.01%
==========================================
Files 139 139
Lines 10223 10225 +2
==========================================
+ Hits 7474 7476 +2
Misses 2308 2308
Partials 441 441
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was always done when running a script, but for archives it was
deemed not needed as if it wasn't needed during the making of the
archive it shouldn't be needed during it's running. The problem arises
when a
requireis in a try block in order (to check if something issupport for example). In that case if it isn't loaded (for example a
nodejs module will not be loaded but will be resolved to an
httpsurl)it will not be cached.
So if someone tries to run an archive from such a
script and there were no https imports k6 will panic at runtime.