Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Always initialize filesystems for all schemes always #1097

Merged
merged 1 commit into from
Aug 5, 2019

Commits on Aug 1, 2019

  1. fix: Always initialize filesystems for all schemes always

    This was always done when running a script, but for archives it was
    deemed not needed as if it wasn't needed during the making of the
    archive it shouldn't be needed during it's running. The problem arises
    when a `require` is in a try block in order (to check if something is
    support for example). In that case if it isn't loaded (for example a
    nodejs module will not be loaded but will be resolved to an `https` url)
    it will not be cached.
    
    So if someone tries to run an archive from such a
    script and there were no https imports k6 will panic at runtime.
    mstoykov committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    ce8afd8 View commit details
    Browse the repository at this point in the history