Update k6/experimental/timers warning and consolidate with browsers #3837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstoykov
added
maintenance
breaking change
mstoykov
requested review from
olegbespalov and
joanlopez
and removed request for
a team
codebien
reviewed
Jul 11, 2024
Co-authored-by: Ivan <2103732+codebien@users.noreply.github.com>
joanlopez
approved these changes
Jul 11, 2024
codebien
approved these changes
Jul 11, 2024
olegbespalov
approved these changes
Jul 11, 2024
| @@ -43,12 +43,13 @@ func getInternalJSModules() map[string]interface{} { | |||
| "k6/experimental/webcrypto": webcrypto.New(), | |||
| "k6/experimental/websockets": &expws.RootModule{}, | |||
| "k6/experimental/timers": newWarnExperimentalModule(timers.New(), | |||
| "k6/experimental/timers is now part of the k6 core, please change your imports to use k6/timers instead."+ | |||
| " The k6/experimental/timers will be removed in k6 v0.52.0"), | |||
| "Please update your imports to use k6/timers instead of k6/experimental/timers,"+ | |||
There was a problem hiding this comment.
Should we promote globally available timers instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Update k6/experimental/timers warning as we missed to dropp it in v0.52.0 and it seems to still be fairly used.
Also mae it the same as for experimental/browser
Why?
To give more time to users and to be more useful.
Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)