Drop experimental timers #3838
Open
Drop experimental timers #3838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstoykov
requested review from
olegbespalov and
joanlopez
and removed request for
a team
mstoykov
added
the
breaking change
joanlopez
previously approved these changes
Jul 11, 2024
| " which will be removed after September 23rd, 2024(v0.54.0). Ensure your scripts are migrated by then."+ | ||
| " There are no API changes, so this is a drop in replacement."), | ||
| "k6/experimental/timers": newRemovedModule( | ||
| "k6/experimental/timers has been graduated, please use k6/timers instead."), |
There was a problem hiding this comment.
Aren't timers globally available? 🤔
There was a problem hiding this comment.
Hmm ... yeah I guess we can just recommend people to use that instead 🤔
There was a problem hiding this comment.
To be honest I mostly opened this so we don't forget to remove them again :)
There was a problem hiding this comment.
Yep, I got that. I should write this in #3837 (comment) earlier, sorry for that 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Drop k6/experimental/timers
Why?
We have stabilized the API and it is now available for k6/timers for some time. We would like to stop supporting the old import path.
Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)