-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop experimental timers #3838
base: master
Are you sure you want to change the base?
Drop experimental timers #3838
Conversation
" which will be removed after September 23rd, 2024(v0.54.0). Ensure your scripts are migrated by then."+ | ||
" There are no API changes, so this is a drop in replacement."), | ||
"k6/experimental/timers": newRemovedModule( | ||
"k6/experimental/timers has been graduated, please use k6/timers instead."), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aren't timers globally available? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm ... yeah I guess we can just recommend people to use that instead 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest I mostly opened this so we don't forget to remove them again :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, I got that. I should write this in #3837 (comment) earlier, sorry for that 😅
What?
Drop k6/experimental/timers
Why?
We have stabilized the API and it is now available for k6/timers for some time. We would like to stop supporting the old import path.
Checklist
make lint
) and all checks pass.make tests
) and all tests pass.Related PR(s)/Issue(s)