Support adding annotations to all service's templates #8627
Comments
|
+1 - it is best practice to allow annotation configuration for all sorts of reasons. Service Mesh config, Monitoring Service Discovery, ... would be great to have them. |
|
+1 Waiting for the same functionality. Is this planned? Please also add this for the single binary service. |
3 tasks
|
Any chance this is going to be deployed soon? |
rubenvw-ngdata
added a commit
to rubenvw-ngdata/loki
that referenced
this issue
Sep 7, 2023
Support setting labels and annotations for all services in the Helm chart. Move label configuration for read, write and table manager services to #component.service.labels to improve consistency between components.
MichelHollands
pushed a commit
that referenced
this issue
Sep 7, 2023
**What this PR does / why we need it**: Support setting labels and annotations for all services in the Helm chart. Move label configuration for read, write and gateway services to #component.service.labels to improve consistency between services. **Which issue(s) this PR fixes**: Fixes #8627 **Special notes for your reviewer**: **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [x] `CHANGELOG.md` updated - [x] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](d10549e)
rhnasc
pushed a commit
to inloco/loki
that referenced
this issue
Apr 12, 2024
**What this PR does / why we need it**: Support setting labels and annotations for all services in the Helm chart. Move label configuration for read, write and gateway services to #component.service.labels to improve consistency between services. **Which issue(s) this PR fixes**: Fixes grafana#8627 **Special notes for your reviewer**: **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [x] `CHANGELOG.md` updated - [x] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](grafana@d10549e)
mraboosk
pushed a commit
to mraboosk/loki
that referenced
this issue
Oct 7, 2024
**What this PR does / why we need it**: Support setting labels and annotations for all services in the Helm chart. Move label configuration for read, write and gateway services to #component.service.labels to improve consistency between services. **Which issue(s) this PR fixes**: Fixes grafana#8627 **Special notes for your reviewer**: **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [x] `CHANGELOG.md` updated - [x] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](grafana@2cef71e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I want to use "Topology Aware Hints" feature of Kubernetes, but currently the helm chart templatefor
serviceonly support adding annotation for gateway nodes.Could you please add annotation support to all other targets like read/write/backend?
The text was updated successfully, but these errors were encountered: