Helm: Add service labels and annotations #10214
Conversation
|
|
rubenvw-ngdata
force-pushed
the
#8627_helm_service_annotations
branch
2 times, most recently
from
d3e4c3d to
b98f265
Compare
github-actions
bot
added
the
type/docs
rubenvw-ngdata
force-pushed
the
#8627_helm_service_annotations
branch
5 times, most recently
from
427d3b1 to
d84668a
Compare
|
Is this going to be reviewed soon? We are waiting for this functionality. |
rubenvw-ngdata
force-pushed
the
#8627_helm_service_annotations
branch
2 times, most recently
from
c0977ce to
bc2759d
Compare
|
@rubenvw-ngdata Thanks for this contribution. Can you fix the issues raised by CI? |
|
@rubenvw-ngdata Also, can you use version 5.17? That would help with some another PR waiting to be merged. |
|
@rubenvw-ngdata I updated this but have encountered a problem. I'll come back to this tomorrow. |
|
@MichelHollands Any update on this? Anything I should still do? |
@rubenvw-ngdata Sorry, I'm busy with some other things. Can you check why the CI run fails? If that is fixed it can be merged. |
There was a problem hiding this comment.
The templates are currently failing to render, at least with ci/default-values.yaml. Are you able to run a helm template locally using those values? I've tried and it fails, seems to be a problem with the format of the yaml templates as I keep getting the error converting YAML to JSON error.
production/helm/loki/templates/backend/service-backend-headless.yaml
Outdated
Show resolved
Hide resolved
production/helm/loki/templates/backend/service-backend-headless.yaml
Outdated
Show resolved
Hide resolved
|
@trevorlauder I think the helm template issue is an issue that was recently introduced on main. |
|
@rubenvw-ngdata You are right: it was a problem on the main branch. It is failing for a different reason now. |
rubenvw-ngdata
force-pushed
the
#8627_helm_service_annotations
branch
from
862a65f to
0366ead
Compare
Support setting labels and annotations for all services in the Helm chart. Move label configuration for read, write and table manager services to #component.service.labels to improve consistency between components.
rubenvw-ngdata
force-pushed
the
#8627_helm_service_annotations
branch
from
0366ead to
9bc1c84
Compare
|
@trevorwhitney @MichelHollands I think everything is ok now. Let me know if I should do anything else. |
MichelHollands
dismissed
trevorwhitney’s stale review
The requested changes were applied. Dismissing so I can merge.
@rubenvw-ngdata Thanks for your help and sorry for the hold-up. It is merged now. |
**What this PR does / why we need it**: Support setting labels and annotations for all services in the Helm chart. Move label configuration for read, write and gateway services to #component.service.labels to improve consistency between services. **Which issue(s) this PR fixes**: Fixes grafana#8627 **Special notes for your reviewer**: **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [x] `CHANGELOG.md` updated - [x] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](grafana@d10549e)
**What this PR does / why we need it**: Support setting labels and annotations for all services in the Helm chart. Move label configuration for read, write and gateway services to #component.service.labels to improve consistency between services. **Which issue(s) this PR fixes**: Fixes grafana#8627 **Special notes for your reviewer**: **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [x] `CHANGELOG.md` updated - [x] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](grafana@2cef71e)
What this PR does / why we need it:
Support setting labels and annotations for all services in the Helm chart.
Move label configuration for read, write and gateway services to #component.service.labels to improve
consistency between services.
Which issue(s) this PR fixes:
Fixes #8627
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)CHANGELOG.mdupdatedproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PR