Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ksonnet): named parameters for containerPort #1756

Merged
merged 1 commit into from
Feb 27, 2020
Merged

Conversation

sh0rez
Copy link
Member

@sh0rez sh0rez commented Feb 27, 2020

Because ksonnet-lib switched the order of the containerPort.new()
parameters from ksonnet.beta.3 to ksonnet.beta.4, we have to use
named parameters to avoid invalid resources when using one of these versions.

Because ksonnet-lib switched the order of the `containerPort.new()`
parameters from `ksonnet.beta.3` to `ksonnet.beta.4`, we have to use
named parameters to avoid invalid resources when using one of these versions.
@sh0rez
Copy link
Member Author

sh0rez commented Feb 27, 2020

/cc @rfratto @cyriltovena

Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slim-bean slim-bean merged commit d42859c into master Feb 27, 2020
@slim-bean slim-bean deleted the named-port-new branch February 27, 2020 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants