Helm chart: Update grafana install instructions #2943
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #2943 +/- ##
==========================================
- Coverage 61.75% 61.74% -0.01%
==========================================
Files 182 182
Lines 14863 14863
==========================================
- Hits 9178 9177 -1
Misses 4839 4839
- Partials 846 847 +1
|
`stable/grafna` is deprecated and no longer indexed by default for helm 3. helm 2 is unsupported. The helm chart is maintained in https://github.com/grafana/helm-charts which requires a `halm add`. Update the instructions to use the loki helm chart that provides grafana out of the box and automatic setup of the data source.
|
This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
I would still like to have this merged in if it's possible. Maybe @slim-bean can help out? |
stale
bot
removed
the
stale
|
I'd suggest this PR be closed in favor of #3084. |
|
@unguiculus makes sense! I will close this PR then 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
stable/grafnais deprecated and no longer indexed by default for helm 3.helm 2 is unsupported. The helm chart is maintained in
https://github.com/grafana/helm-charts which requires a
halm add.Update the instructions to use the loki helm chart that provides grafana
out of the box and automatic setup of the data source.
Special notes for your reviewer:
docs/sources/installation/helm.mdandproduction/helm/README.mdseem to be duplicated documentation, would it make sense to have them as a symlink in the future so we don't have to update both files with the same changes?Checklist