Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reference to old helm chart repo #3084

Merged
merged 1 commit into from
Jan 4, 2021
Merged

Update reference to old helm chart repo #3084

merged 1 commit into from
Jan 4, 2021

Conversation

ilpianista
Copy link
Contributor

What this PR does / why we need it:

Remove old references to the old Helm chart repo and to Tiller.
Special notes for your reviewer:

This is a follow-up of #2720.

@CLAassistant
Copy link

CLAassistant commented Dec 16, 2020

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

Codecov Report

Merging #3084 (677a183) into master (e9001d8) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3084      +/-   ##
==========================================
+ Coverage   62.86%   62.90%   +0.03%     
==========================================
  Files         186      186              
  Lines       15949    15949              
==========================================
+ Hits        10026    10032       +6     
+ Misses       4996     4992       -4     
+ Partials      927      925       -2     
Impacted Files Coverage Δ
pkg/promtail/targets/file/tailer.go 78.37% <0.00%> (+5.40%) ⬆️

Copy link
Contributor

@unguiculus unguiculus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the help!

@owen-d owen-d merged commit 3640d2d into grafana:master Jan 4, 2021
@ilpianista ilpianista deleted the bugfix/new-chart-repo branch January 4, 2021 16:34
mraboosk pushed a commit to mraboosk/loki that referenced this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants