Fixes vector grouping injection. #2975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During an improvement I introduced a bug where we would pre-aggregate some range vector aggregations, although the result is not the same. We can only inject vector grouping in range vector if the operation is associative through grouping. This is not the case for max/min/stddev/stddvar/quantile/avg_over_time. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
owen-d
reviewed
Nov 24, 2020
| return r.extractor(e.grouping, len(e.grouping.groups) == 0) | ||
| } | ||
| return e.left.Extractor() | ||
| } | ||
|
|
||
| // canInjectVectorGrouping tells if a vector operation can inject grouping into the nested range vector. | ||
| func canInjectVectorGrouping(vecOp, rangeOp string) bool { | ||
| if vecOp != OpTypeSum { |
There was a problem hiding this comment.
This should work with other types as well (min, max, count), right?
There was a problem hiding this comment.
I know from fact that it doesn't work with count, we have a test in sharding that fails.
It might work for max and min but I don't have a test backing me up.
There was a problem hiding this comment.
This basically deserves a big test harness.
owen-d
approved these changes
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During an improvement I introduced a bug where we would pre-aggregate some range vector
aggregations, although the result is not the same.
We can only inject vector grouping in range vector if the operation is associative through grouping.
This is not the case for max/min/stddev/stddvar/quantile/avg_over_time.
Signed-off-by: Cyril Tovena cyril.tovena@gmail.com