Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes vector grouping injection. #2975

Merged
merged 2 commits into from
Nov 25, 2020
Merged

Fixes vector grouping injection. #2975

merged 2 commits into from
Nov 25, 2020

Commits on Nov 23, 2020

  1. Fixes vector grouping injection. 

    During an improvement I introduced a bug where we would pre-aggregate some range vector
aggregations, although the result is not the same.

We can only inject vector grouping in range vector if the operation is associative through grouping.

This is not the case for max/min/stddev/stddvar/quantile/avg_over_time.

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
    @cyriltovena
    cyriltovena committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    2ff9a36 View commit details
    Browse the repository at this point in the history

  2. got linted. 

    Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
    @cyriltovena
    cyriltovena committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    ff9fd69 View commit details
    Browse the repository at this point in the history